linux-kernel - Re: [PATCH] rust: adds bindings for bitmap.c and bitops.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACQBu=UC-DmLGpg30=Dyp5hhWV7HGXG+bL73YBSq5vSa4t3mig@mail.gmail.com>
Date: Wed, 19 Mar 2025 14:58:14 +0100
From: Burak Emir <bqe@...gle.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>, Yury Norov <yury.norov@...il.com>
Cc: Rasmus Villemoes <linux@...musvillemoes.dk>, Viresh Kumar <viresh.kumar@...aro.org>, 
	Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: adds bindings for bitmap.c and bitops.c

On Wed, Mar 19, 2025 at 1:46 PM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
>
> On Wed, Mar 19, 2025 at 12:31 PM Burak Emir <bqe@...gle.com> wrote:
> >
> > Part of a series that introduces Rust Bitmap API that has received
> > a few rounds of review. Thanks for the helpful review comments.
> >
> > Rebased on next-20250318 and split as requested in
> > https://lore.kernel.org/all/Z9nAVIokrWqoRiFR@thinkpad/
>
> I am not sure Yury meant to make it an independent patch, but rather a
> different patch in the series.
>
> Doing it this way means we add helpers that are unused, which I don't
> think he would like, and we also normally don't do that either.

Thanks, I was unsure about this. I understand the desire to not add dead code.
Yet, next-20250318 does now contain helpers for `cpumask.c` without
corresponding `cpumask.rs`

So, I will include this in v5 of the rebased series, but with BITOPS
API BINDINGS [RUST] in its own patch.
Thanks for bearing with me : )

- Burak