[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <a79697fa-9ac0-4829-a36f-4e9915ad6bff@collabora.com>
Date: Wed, 19 Mar 2025 15:07:13 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Nicolas Dufresne <nicolas@...fresne.ca>, chunkuang.hu@...nel.org,
Yunfei Dong <yunfei.dong@...iatek.com>,
Jason-JH Lin <jason-jh.lin@...iatek.com>
Cc: p.zabel@...gutronix.de, airlied@...il.com, simona@...ll.ch,
maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de,
robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
mchehab@...nel.org, matthias.bgg@...il.com, moudy.ho@...iatek.com,
dri-devel@...ts.freedesktop.org, linux-mediatek@...ts.infradead.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-media@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
kernel@...labora.com, sebastian.fricke@...labora.com,
macpaul.lin@...iatek.com
Subject: Re: [PATCH v1 2/3] dt-bindings: media: mediatek: mdp3: Add
compatibles for MT8188 MDP3
Il 19/02/25 16:38, Nicolas Dufresne ha scritto:
> Hi Angelo,
>
> Le mercredi 18 décembre 2024 à 11:53 +0100, AngeloGioacchino Del Regno
> a écrit :
>> Add compatible strings for the FG, HDR, RSZ, STITCH, TCC, TDSHP
>> and WROT hardware components found in MediaTek's MT8188 SoC.
>
> The firmware for this is missing in linux-firmware. I will not ack or
> pickMTK-VCODEC/MDP3 patches until this issue has been resolved.
>
Nicolas et al linux-media maintainers:
https://lore.kernel.org/all/CA+5PVA6a+g1rZOM+ZRsNr-e4C9DPagQrffRO36yO3Bt3UXJNfQ@mail.gmail.com/
We ran tests on the firmware that was pushed, and sent the results in
reply to the patch that adds the firmware:
https://lore.kernel.org/all/8049a2ec-b5fe-440d-9704-c3b0e2d610c7@notapiano
The SCP firmware for VCODEC and MDP3 on the MT8188/MT8370/MT8390 SoCs has
been merged in linux-firmware.
Can you please ack this patch now? :-)
Cheers,
Angelo
> regards,
> Nicolas
>
>>
>> This hardware is compatible with MT8195.
>>
>> Signed-off-by: AngeloGioacchino Del Regno
>> <angelogioacchino.delregno@...labora.com>
>> ---
>> .../devicetree/bindings/media/mediatek,mdp3-fg.yaml | 8
>> ++++++--
>> .../devicetree/bindings/media/mediatek,mdp3-hdr.yaml | 8
>> ++++++--
>> .../devicetree/bindings/media/mediatek,mdp3-rsz.yaml | 1 +
>> .../devicetree/bindings/media/mediatek,mdp3-stitch.yaml | 8
>> ++++++--
>> .../devicetree/bindings/media/mediatek,mdp3-tcc.yaml | 8
>> ++++++--
>> .../devicetree/bindings/media/mediatek,mdp3-tdshp.yaml | 8
>> ++++++--
>> .../devicetree/bindings/media/mediatek,mdp3-wrot.yaml | 1 +
>> 7 files changed, 32 insertions(+), 10 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> fg.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> fg.yaml
>> index 03f31b009085..40fda59fa8a8 100644
>> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-fg.yaml
>> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-fg.yaml
>> @@ -16,8 +16,12 @@ description:
>>
>> properties:
>> compatible:
>> - enum:
>> - - mediatek,mt8195-mdp3-fg
>> + oneOf:
>> + - enum:
>> + - mediatek,mt8195-mdp3-fg
>> + - items:
>> + - const: mediatek,mt8188-mdp3-fg
>> + - const: mediatek,mt8195-mdp3-fg
>>
>> reg:
>> maxItems: 1
>> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> hdr.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> hdr.yaml
>> index d4609bba6578..d9f926c20220 100644
>> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-hdr.yaml
>> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-hdr.yaml
>> @@ -16,8 +16,12 @@ description:
>>
>> properties:
>> compatible:
>> - enum:
>> - - mediatek,mt8195-mdp3-hdr
>> + oneOf:
>> + - enum:
>> + - mediatek,mt8195-mdp3-hdr
>> + - items:
>> + - const: mediatek,mt8188-mdp3-hdr
>> + - const: mediatek,mt8195-mdp3-hdr
>>
>> reg:
>> maxItems: 1
>> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> rsz.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> rsz.yaml
>> index f5676bec4326..8124c39d73e9 100644
>> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml
>> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml
>> @@ -20,6 +20,7 @@ properties:
>> - mediatek,mt8183-mdp3-rsz
>> - items:
>> - enum:
>> + - mediatek,mt8188-mdp3-rsz
>> - mediatek,mt8195-mdp3-rsz
>> - const: mediatek,mt8183-mdp3-rsz
>>
>> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> stitch.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> stitch.yaml
>> index d815bea29154..1d8e7e202c42 100644
>> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> stitch.yaml
>> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> stitch.yaml
>> @@ -16,8 +16,12 @@ description:
>>
>> properties:
>> compatible:
>> - enum:
>> - - mediatek,mt8195-mdp3-stitch
>> + oneOf:
>> + - enum:
>> + - mediatek,mt8195-mdp3-stitch
>> + - items:
>> + - const: mediatek,mt8188-mdp3-stitch
>> + - const: mediatek,mt8195-mdp3-stitch
>>
>> reg:
>> maxItems: 1
>> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> tcc.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> tcc.yaml
>> index 14ea556d4f82..6cff7c073ce4 100644
>> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-tcc.yaml
>> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-tcc.yaml
>> @@ -17,8 +17,12 @@ description:
>>
>> properties:
>> compatible:
>> - enum:
>> - - mediatek,mt8195-mdp3-tcc
>> + oneOf:
>> + - enum:
>> + - mediatek,mt8195-mdp3-tcc
>> + - items:
>> + - const: mediatek,mt8188-mdp3-tcc
>> + - const: mediatek,mt8195-mdp3-tcc
>>
>> reg:
>> maxItems: 1
>> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> tdshp.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> tdshp.yaml
>> index 8ab7f2d8e148..cdfa27324738 100644
>> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> tdshp.yaml
>> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> tdshp.yaml
>> @@ -16,8 +16,12 @@ description:
>>
>> properties:
>> compatible:
>> - enum:
>> - - mediatek,mt8195-mdp3-tdshp
>> + oneOf:
>> + - enum:
>> + - mediatek,mt8195-mdp3-tdshp
>> + - items:
>> + - const: mediatek,mt8188-mdp3-tdshp
>> + - const: mediatek,mt8195-mdp3-tdshp
>>
>> reg:
>> maxItems: 1
>> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> wrot.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> wrot.yaml
>> index 53a679338402..b6269f4f9fd6 100644
>> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml
>> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml
>> @@ -20,6 +20,7 @@ properties:
>> - mediatek,mt8183-mdp3-wrot
>> - items:
>> - enum:
>> + - mediatek,mt8188-mdp3-wrot
>> - mediatek,mt8195-mdp3-wrot
>> - const: mediatek,mt8183-mdp3-wrot
>>
>
Powered by blists - more mailing lists