linux-kernel - [PATCH net-next] netpoll: Eliminate redundant assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250319-netpoll_nit-v1-1-a7faac5cbd92@debian.org>
Date: Wed, 19 Mar 2025 10:02:44 -0700
From: Breno Leitao <leitao@...ian.org>
To: "David S. Miller" <davem@...emloft.net>, 
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Breno Leitao <leitao@...ian.org>
Subject: [PATCH net-next] netpoll: Eliminate redundant assignment

The assignment of zero to udph->check is unnecessary as it is
immediately overwritten in the subsequent line. Remove the redundant
assignment.

Signed-off-by: Breno Leitao <leitao@...ian.org>
---
 net/core/netpoll.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index 3cc3eae9def30..4e1dba572f5ac 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -433,7 +433,6 @@ int netpoll_send_udp(struct netpoll *np, const char *msg, int len)
 	udph->len = htons(udp_len);

 	if (np->ipv6) {
-		udph->check = 0;
 		udph->check = csum_ipv6_magic(&np->local_ip.in6,
 					      &np->remote_ip.in6,
 					      udp_len, IPPROTO_UDP,

---
base-commit: 23c9ff659140f97d44bf6fb59f89526a168f2b86
change-id: 20250319-netpoll_nit-6390753708bc

Best regards,
-- 
Breno Leitao <leitao@...ian.org>