linux-kernel - Re: [PATCH] virt: vmgenid: Add Null check for device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9r9T26d7Sk0R9jB@zx2c4.com>
Date: Wed, 19 Mar 2025 18:22:23 +0100
From: "Jason A. Donenfeld" <Jason@...c4.com>
To: Chenyuan Yang <chenyuan0y@...il.com>
Cc: tytso@....edu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] virt: vmgenid: Add Null check for device

On Wed, Mar 12, 2025 at 11:26:00PM -0500, Chenyuan Yang wrote:
> Not all devices have an ACPI companion fwnode, so device might be NULL.
> This is similar to the commit cd2fd6eab480
> ("platform/x86: int3472: Check for adev == NULL").
> 
> Add a check for device not being set and return -ENODEV in that case to
> avoid a possible NULL pointer deref in vmgenid_add_acpi().

Is this causing a crash on some systems? What's happening here? "Not all
devices" - which ones, and why?

Jason