linux-kernel - Re: [PATCH v3 1/1] scsi: ufs: core: add device level exception support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d82ce6c4-ae17-4ac6-9bb9-59759f8a185d@acm.org>
Date: Wed, 19 Mar 2025 10:45:20 -0700
From: Bart Van Assche <bvanassche@....org>
To: "Bao D. Nguyen" <quic_nguyenb@...cinc.com>,
 Peter Wang (王信友) <peter.wang@...iatek.com>,
 "avri.altman@....com" <avri.altman@....com>,
 "quic_cang@...cinc.com" <quic_cang@...cinc.com>,
 "quic_nitirawa@...cinc.com" <quic_nitirawa@...cinc.com>,
 "manivannan.sadhasivam@...aro.org" <manivannan.sadhasivam@...aro.org>,
 "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
 "minwoo.im@...sung.com" <minwoo.im@...sung.com>,
 "martin.petersen@...cle.com" <martin.petersen@...cle.com>
Cc: "beanhuo@...ron.com" <beanhuo@...ron.com>,
 "ebiggers@...gle.com" <ebiggers@...gle.com>,
 "gwendal@...omium.org" <gwendal@...omium.org>,
 "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 "quic_ziqichen@...cinc.com" <quic_ziqichen@...cinc.com>,
 "alim.akhtar@...sung.com" <alim.akhtar@...sung.com>,
 "keosung.park@...sung.com" <keosung.park@...sung.com>,
 "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
 "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
 "James.Bottomley@...senPartnership.com"
 <James.Bottomley@...senPartnership.com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
 "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 1/1] scsi: ufs: core: add device level exception
 support

On 3/19/25 2:01 AM, Bao D. Nguyen wrote:
> On 3/19/2025 12:56 AM, Peter Wang (王信友) wrote:
>> Could use atomic_t for counter protect?
>
> Are you suggesting to convert the dev_lvl_exception_count type from u32 
> to atomic_t type? Because the value of dev_lvl_exception_count is 
> returned to the user space via the device_lvl_exception_count_show() 
> using the sysfs_emit() function, keeping the dev_lvl_exception_count as 
> u32 data type probably works better in terms of the format.

I like the suggestion to use atomic_t. atomic_read() can be used in the
sysfs show method.

Thanks,

Bart.