linux-kernel - Re: [PATCH 1/2] rust: pci: require Send for Driver trait implementers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025031938-dismiss-specked-a590@gregkh>
Date: Wed, 19 Mar 2025 10:55:59 -0700
From: Greg KH <gregkh@...uxfoundation.org>
To: Danilo Krummrich <dakr@...nel.org>
Cc: bhelgaas@...gle.com, rafael@...nel.org, ojeda@...nel.org,
	alex.gaynor@...il.com, boqun.feng@...il.com, gary@...yguo.net,
	bjorn3_gh@...tonmail.com, benno.lossin@...ton.me,
	a.hindborg@...nel.org, aliceryhl@...gle.com, tmgross@...ch.edu,
	linux-pci@...r.kernel.org, rust-for-linux@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] rust: pci: require Send for Driver trait implementers

On Wed, Mar 19, 2025 at 06:11:13PM +0100, Danilo Krummrich wrote:
> On Wed, Mar 19, 2025 at 10:03:49AM -0700, Greg KH wrote:
> > On Wed, Mar 19, 2025 at 03:52:55PM +0100, Danilo Krummrich wrote:
> > > The instance of Self, returned and created by Driver::probe() is
> > > dropped in the bus' remove() callback.
> > > 
> > > Request implementers of the Driver trait to implement Send, since the
> > > remove() callback is not guaranteed to run from the same thread as
> > > probe().
> > > 
> > > Fixes: 1bd8b6b2c5d3 ("rust: pci: add basic PCI device / driver abstractions")
> > > Reported-by: Alice Ryhl <aliceryhl@...gle.com>
> > > Closes: https://lore.kernel.org/lkml/Z9rDxOJ2V2bPjj5i@google.com/
> > > Signed-off-by: Danilo Krummrich <dakr@...nel.org>
> > > ---
> > >  rust/kernel/pci.rs | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > As there's no in-kernel users of these, any objection for me to take
> > them for 6.15-rc1, or should they go now to Linus for 6.14-final?
> 
> I think it's fine to take them for 6.15-rc1 only.
> 
> --
> 
> Note that, while those patches can be taken "as is" to stable trees, they
> require
> 
> 	rust: platform: impl Send + Sync for platform::Device
> 	rust: pci: impl Send + Sync for pci::Device
> 
> as well, if
> 
> 	7b948a2af6b5 ("rust: pci: fix unrestricted &mut pci::Device")
> 	4d320e30ee04 ("rust: platform: fix unrestricted &mut platform::Device")
> 
> are in the same tree.

Cool, I'll deal with that in a few weeks when -rc1 is out, thanks for
the warning.

greg k-h