linux-kernel - Re: [PATCH net-next v4 3/3] net: stmmac: Add DWMAC glue layer for Renesas GBETH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202503200200.WXMnn3Kq-lkp@intel.com>
Date: Thu, 20 Mar 2025 02:30:45 +0800
From: kernel test robot <lkp@...el.com>
To: Prabhakar <prabhakar.csengg@...il.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Magnus Damm <magnus.damm@...il.com>,
	"Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
	Giuseppe Cavallaro <peppe.cavallaro@...com>,
	Jose Abreu <joabreu@...opsys.com>
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org,
	Prabhakar <prabhakar.csengg@...il.com>,
	Biju Das <biju.das.jz@...renesas.com>,
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH net-next v4 3/3] net: stmmac: Add DWMAC glue layer for
 Renesas GBETH

Hi Prabhakar,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Prabhakar/dt-bindings-net-dwmac-Increase-maxItems-for-interrupts-and-interrupt-names/20250319-050021
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250318205735.122590-4-prabhakar.mahadev-lad.rj%40bp.renesas.com
patch subject: [PATCH net-next v4 3/3] net: stmmac: Add DWMAC glue layer for Renesas GBETH
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20250320/202503200200.WXMnn3Kq-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250320/202503200200.WXMnn3Kq-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503200200.WXMnn3Kq-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/net/ethernet/stmicro/stmmac/dwmac-renesas-gbeth.c: In function 'renesas_gbeth_probe':
>> drivers/net/ethernet/stmicro/stmmac/dwmac-renesas-gbeth.c:125:7: error: 'STMMAC_FLAG_EN_TX_LPI_CLK_PHY_CAP' undeclared (first use in this function); did you mean 'STMMAC_FLAG_EN_TX_LPI_CLOCKGATING'?
          STMMAC_FLAG_EN_TX_LPI_CLK_PHY_CAP |
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          STMMAC_FLAG_EN_TX_LPI_CLOCKGATING
   drivers/net/ethernet/stmicro/stmmac/dwmac-renesas-gbeth.c:125:7: note: each undeclared identifier is reported only once for each function it appears in


vim +125 drivers/net/ethernet/stmicro/stmmac/dwmac-renesas-gbeth.c

    72	
    73	static int renesas_gbeth_probe(struct platform_device *pdev)
    74	{
    75		struct plat_stmmacenet_data *plat_dat;
    76		struct stmmac_resources stmmac_res;
    77		struct device *dev = &pdev->dev;
    78		struct renesas_gbeth *gbeth;
    79		unsigned int i;
    80		int err;
    81	
    82		err = stmmac_get_platform_resources(pdev, &stmmac_res);
    83		if (err)
    84			return dev_err_probe(dev, err,
    85					     "failed to get resources\n");
    86	
    87		plat_dat = devm_stmmac_probe_config_dt(pdev, stmmac_res.mac);
    88		if (IS_ERR(plat_dat))
    89			return dev_err_probe(dev, PTR_ERR(plat_dat),
    90					     "dt configuration failed\n");
    91	
    92		gbeth = devm_kzalloc(dev, sizeof(*gbeth), GFP_KERNEL);
    93		if (!gbeth)
    94			return -ENOMEM;
    95	
    96		plat_dat->num_clks = ARRAY_SIZE(renesas_gbeth_clks);
    97		plat_dat->clks = devm_kcalloc(dev, plat_dat->num_clks,
    98					      sizeof(*plat_dat->clks), GFP_KERNEL);
    99		if (!plat_dat->clks)
   100			return -ENOMEM;
   101	
   102		for (i = 0; i < plat_dat->num_clks; i++)
   103			plat_dat->clks[i].id = renesas_gbeth_clks[i];
   104	
   105		err = devm_clk_bulk_get(dev, plat_dat->num_clks, plat_dat->clks);
   106		if (err < 0)
   107			return err;
   108	
   109		plat_dat->clk_tx_i = renesas_gbeth_find_clk(plat_dat, "tx");
   110		if (!plat_dat->clk_tx_i)
   111			return dev_err_probe(dev, -EINVAL,
   112					     "error finding tx clock\n");
   113	
   114		gbeth->rstc = devm_reset_control_get_exclusive(dev, NULL);
   115		if (IS_ERR(gbeth->rstc))
   116			return PTR_ERR(gbeth->rstc);
   117	
   118		gbeth->dev = dev;
   119		gbeth->regs = stmmac_res.addr;
   120		gbeth->plat_dat = plat_dat;
   121		plat_dat->bsp_priv = gbeth;
   122		plat_dat->set_clk_tx_rate = stmmac_set_clk_tx_rate;
   123		plat_dat->clks_config = renesas_gbeth_clks_config;
   124		plat_dat->flags |= STMMAC_FLAG_HWTSTAMP_CORRECT_LATENCY |
 > 125				   STMMAC_FLAG_EN_TX_LPI_CLK_PHY_CAP |
   126				   STMMAC_FLAG_SPH_DISABLE;
   127	
   128		err = renesas_gbeth_clks_config(gbeth, true);
   129		if (err)
   130			return err;
   131	
   132		err = stmmac_dvr_probe(dev, plat_dat, &stmmac_res);
   133		if (err)
   134			renesas_gbeth_clks_config(gbeth, false);
   135	
   136		return err;
   137	}
   138	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki