linux-kernel - Re: [lvc-project] [PATCH] cifs: avoid NULL pointer dereference in dbg call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH2r5muCakSQSh_Epm5eFDPnFu=_Ayc-wwd7a7t+FrKxziz5DA@mail.gmail.com>
Date: Wed, 19 Mar 2025 14:30:10 -0500
From: Steve French <smfrench@...il.com>
To: Alexandra Diupina <adiupina@...ralinux.ru>
Cc: Fedor Pchelkin <pchelkin@...ras.ru>, Steve French <sfrench@...ba.org>, 
	Paulo Alcantara <pc@...guebit.com>, linux-cifs@...r.kernel.org, 
	Shyam Prasad N <sprasad@...rosoft.com>, samba-technical@...ts.samba.org, 
	Aurelien Aptel <aaptel@...e.com>, linux-kernel@...r.kernel.org, Tom Talpey <tom@...pey.com>, 
	Bharath SM <bharathsm@...rosoft.com>, Ronnie Sahlberg <ronniesahlberg@...il.com>, 
	Pavel Shilovsky <pshilov@...rosoft.com>, lvc-project@...uxtesting.org
Subject: Re: [lvc-project] [PATCH] cifs: avoid NULL pointer dereference in dbg call

I don't mind if you also send patches as attachments (or with pointer
to git or github commit link), especially if your email is corrupting
whitespace

On Wed, Mar 19, 2025 at 9:33 AM Alexandra Diupina
<adiupina@...ralinux.ru> wrote:
>
>
>
>
> 19/03/25 16:20, Fedor Pchelkin пишет:
> > On Wed, 19. Mar 15:31, Alexandra Diupina wrote:
> >> diff --git a/fs/smb/client/smb2misc.c b/fs/smb/client/smb2misc.c
> >> index f3c4b70b77b9..c02aab58aade 100644
> >> --- a/fs/smb/client/smb2misc.c
> >> +++ b/fs/smb/client/smb2misc.c
> >> @@ -816,11 +816,12 @@ smb2_handle_cancelled_close(struct cifs_tcon *tcon, __u64 persistent_fid,
> >>              WARN_ONCE(tcon->tc_count < 0, "tcon refcount is negative");
> >>              spin_unlock(&cifs_tcp_ses_lock);
> >>
> >> -            if (tcon->ses)
> >> +            if (tcon->ses) {
> >>                      server = tcon->ses->server;
> >> -
> >> -            cifs_server_dbg(FYI, "tid=0x%x: tcon is closing, skipping async close retry of fid %llu %llu\n",
> >> -                            tcon->tid, persistent_fid, volatile_fid);
> >> +                    cifs_server_dbg(FYI,
> >> +                                                    "tid=0x%x: tcon is closing, skipping async close retry of fid %llu %llu\n",
> >> +                                                    tcon->tid, persistent_fid, volatile_fid);
> >> +            }
> > Something is wrong with the indentation. Usually scripts/checkpatch.pl
> > can give some feedback on this, too.
> >
> > CHECK: Alignment should match open parenthesis
> > #32: FILE: fs/smb/client/smb2misc.c:822:
> > +                     cifs_server_dbg(FYI,
> > +                                                     "tid=0x%x: tcon is closing, skipping async close retry of fid %llu %llu\n",
>
> In the *.patch file, everything was fine with indents,
> so the checkpatch.pl script completed without errors.
> But when sending, the indents got corrupted for some
> reason. I'll send the second version
> >
> >>
> >>              return 0;
> >>      }
> >> --
> >> 2.30.2
>
>


-- 
Thanks,

Steve