linux-kernel - Re: [PATCH 1/5] dt-bindings: display: mediatek: mdp-rsz: Add rules for MT8196

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250319-footnote-trusting-230e509bed07@spud>
Date: Wed, 19 Mar 2025 20:00:19 +0000
From: Conor Dooley <conor@...nel.org>
To: Sunny Shen (沈姍姍) <Sunny.Shen@...iatek.com>
Cc: "robh@...nel.org" <robh@...nel.org>,
	Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>,
	Project_Global_Chrome_Upstream_Group <Project_Global_Chrome_Upstream_Group@...iatek.com>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
	Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>,
	"fshao@...omium.org" <fshao@...omium.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	Singo Chang (張興國) <Singo.Chang@...iatek.com>,
	Paul-pl Chen (陳柏霖) <Paul-pl.Chen@...iatek.com>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
	"treapking@...omium.org" <treapking@...omium.org>
Subject: Re: [PATCH 1/5] dt-bindings: display: mediatek: mdp-rsz: Add rules
 for MT8196

On Tue, Mar 18, 2025 at 03:14:07AM +0000, Sunny Shen (沈姍姍) wrote:
> On Mon, 2025-02-24 at 19:01 +0000, Conor Dooley wrote:
> > On Sun, Feb 23, 2025 at 05:49:45PM +0000, Sunny Shen (沈姍姍) wrote:
> > > On Tue, 2025-02-11 at 17:54 +0000, Conor Dooley wrote:
> > > > On Tue, Feb 11, 2025 at 10:52:50AM +0800, Sunny Shen wrote:
> > > > > Add MDP-RSZ hardware description for MediaTek MT8196 SoC
> > 
> > > > > +examples:
> > > > > +  - |
> > > > > +    soc {
> > > > > +        #address-cells = <2>;
> > > > > +        #size-cells = <2>;
> > > > > +
> > > > > +        disp_mdp_rsz0: disp-mdp-rsz0@...a0000 {
> > > > 
> > > > And "disp-mdp-rsz0" isn't anything close to a generic node name.
> > > 
> > > Will modify "disp-mdp-rsz0@...a0000" to "mdp-rsz@...a0000"
> > 
> > I don't think that's an improvement. Hint: full words would be a good
> > place to start
> 
>  
> Hi Conor,
> 
> About full words, 
> Do you mean words like this? 
> multimedia-display-path-resizer?
> or mdp-resizer?

These are both improvements on what you've got right now.

> We found that "mdp-rsz" this kind of word is used at
> https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> 
> I'm not sure what will be better.
> Can you provide more detailed suggestion about this naming?

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)