linux-kernel - Re: [PATCH 00/11] HID: asus: hid-asus and asus-wmi backlight unification, Z13 QOL improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <CAGwozwFRScPtHnnBGe-tftbBqYNM1hAsdGtowSdOpmpaq_Vh7g@mail.gmail.com>
Date: Wed, 19 Mar 2025 22:50:30 +0100
From: Antheas Kapenekakis <lkml@...heas.dev>
To: platform-driver-x86@...r.kernel.org, linux-input@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, Jiri Kosina <jikos@...nel.org>,
	Benjamin Tissoires <bentiss@...nel.org>,
 Corentin Chary <corentin.chary@...il.com>,
	"Luke D . Jones" <luke@...nes.dev>, Hans de Goede <hdegoede@...hat.com>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	"Limonciello, Mario" <Mario.Limonciello@....com>
Subject: Re: [PATCH 00/11] HID: asus: hid-asus and asus-wmi backlight
 unification, Z13 QOL improvements

On Wed, 19 Mar 2025 at 22:38, Antheas Kapenekakis <lkml@...heas.dev> wrote:
>
> This is a three part series that does the following: first, it cleans up
> the hid-asus driver initialization, preventing excess renames and dmesg
> errors on ROG devices. Then, it adds support for the Z13 2025 keyboard,
> by fixing its keyboard to not be stuck in BIOS mode and enabling its fan
> key. Finally, the bigger piece of this series is the unification of the
> backlight controls between hid-asus and asus-wmi.
>
> <snip>
> --
> 2.48.1
>

Update on this. I made a minor refactor today to fix some edge cases
where it was obvious the mutex was not guarding stuff and ended up
locking during unregistering in this series. So skip testing it.

I'll send the fixed version tomorrow, in the meantime you can find it
here [1]. Fixes were very minor, moving the mutexes around in 2
places, so feel free to comment on this series.

Also, the init delay seems to not have worked for the mouse touchpad
bug. Seems like 5 reboots were not enough testing. I will say it is
peculiar that hid-generic works properly, when this series makes
hid-asus mimic it very closely. Also, one rmmod to hid-asus fixes
this, regardless of how many times hid-asus is reloaded afterwards.

Antheas

+CC Mario in case you want to review

[1] https://github.com/bazzite-org/patchwork/tree/upstream/asusrgb