linux-kernel - Re: [PATCH v5 2/2] arm64: dts: amlogic: add support for xiaomi-aquaman/Mi TV Stick

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFBinCArRO-F59tOv9m27f+DV+qhy69OGUunGOAbDdfOdd5_Xg@mail.gmail.com>
Date: Wed, 19 Mar 2025 23:36:14 +0100
From: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To: Ferass El Hafidi <funderscore@...tmarketos.org>
Cc: Neil Armstrong <neil.armstrong@...aro.org>, Kevin Hilman <khilman@...libre.com>, 
	Jerome Brunet <jbrunet@...libre.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-amlogic@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	~postmarketos/upstreaming@...ts.sr.ht, Artur Weber <aweber.kernel@...il.com>, 
	Karl Chan <exxxxkc@...googleoff.me>, Christian Hewitt <christianshewitt@...il.com>
Subject: Re: [PATCH v5 2/2] arm64: dts: amlogic: add support for
 xiaomi-aquaman/Mi TV Stick

Hello,

thanks for your contribution and sorry for the late reply!

On Wed, Mar 19, 2025 at 8:02 PM Ferass El Hafidi
<funderscore@...tmarketos.org> wrote:
[...]
> +       au2: analog-amplifier {
> +               compatible = "simple-audio-amplifier";
> +               sound-name-prefix = "AU2";
> +               VCC-supply = <&vcc_5v>;
> +               enable-gpios = <&gpio GPIOH_5 GPIO_ACTIVE_HIGH>;
> +       };
I couldn't find any pictures online that show an analog audio output
(typically a 3.5mm socket).
Can you confirm that this is really present?

[...]
> +       sound {
> +               compatible = "amlogic,gx-sound-card";
> +               model = "XIAOMI-AQUAMAN";
> +               audio-aux-devs = <&au2>;
> +               audio-widgets = "Line", "Lineout";
> +               audio-routing = "AU2 INL", "ACODEC LOLN",
> +                               "AU2 INR", "ACODEC LORN",
> +                               "Lineout", "AU2 OUTL",
> +                               "Lineout", "AU2 OUTR";
If there's no analog audio in/out then this section can be cleaned up
as well - together with the references to acodec in the dai-links
below.

[...]
> +/* Wireless SDIO Module (Amlogic W155S1 / Realtek RTL8821CS) */
> +&sd_emmc_b {
question to Neil: since we know that there's two board variants out
there (with different wifi chipsets) - are dt overlays down the road
enough (to enable Bluetooth / wifi - depending on the chipset or board
revision) or do we need to split the whole .dts?


Best regards,
Martin