linux-kernel - Re: [PATCH v3 1/2] dt-bindings: iio: light: bh1750: Add reset-gpios property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96c44905-0725-4c68-91a5-1c6cea6a7f4a@pereznus.es>
Date: Wed, 19 Mar 2025 23:38:09 +0100
From: Sergio Pérez <sergio@...eznus.es>
To: Krzysztof Kozlowski <krzk@...nel.org>,
 Tomasz Duszynski <tduszyns@...il.com>, Jonathan Cameron <jic23@...nel.org>,
 Lars-Peter Clausen <lars@...afoo.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: iio: light: bh1750: Add reset-gpios
 property


El 19/03/2025 a las 20:12, Krzysztof Kozlowski escribió:
> On 19/03/2025 17:11, Sergio Perez wrote:
>> Some BH1750 sensors require a hardware reset via GPIO before they can
>> be properly detected on the I2C bus. Add a new reset-gpios property
>> to the binding to support this functionality.
>>
>> The reset-gpios property allows specifying a GPIO that will be toggled
>> during driver initialization to reset the sensor.
>>
>> Signed-off-by: Sergio Perez <sergio@...eznus.es>
>> ---
>>   Documentation/devicetree/bindings/iio/light/bh1750.yaml | 5 +++++
>>   1 file changed, 5 insertions(+)
> You just sent v3, while v4 was already on the lists, without improving
> and without responding to review.
>
> NAK.
>
> You keep repeating the same mistakes: not reading and responding
> feedback and it is getting tiresome.
I apologize for the confusion with patch versions. You're right that I 
sent v3
after v4 was already on the list. I was trying to follow your exact 
instructions from:
"git add ...
git commit --signed-off
git format-patch -v3 -2
scripts/chekpatch.pl v3*
scripts/get_maintainers.pl --no-git-fallback v3*
git send-email *"

Regarding the binding I've modified for next v5 the YAML description to 
remove "active low" to avoid confusion and modified the example to:

examples:
   - |
     i2c {
       #address-cells = <1>;
       #size-cells = <0>;

       light-sensor@23 {
         compatible = "rohm,bh1750";
         reg = <0x23>;
         reset-gpios = <&gpio2 17 GPIO_ACTIVE_HIGH>;
       };
     };

That is the original version and is the configuration running on my machine.

> Best regards,
> Krzysztof