linux-kernel - Re: [PATCH] ARM: dts: nokia n900: remove useless io-channel-cells property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <jqvulfqjjscwyjw7yzmnfxlwj6p3qnazfjddlhasof5qbtmu55@mb6om3fbalon>
Date: Wed, 19 Mar 2025 23:56:29 +0100
From: Sebastian Reichel <sre@...nel.org>
To: David Heidelberg <david@...t.cz>
Cc: Tony Lindgren <tony@...mide.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Pavel Machek <pavel@....cz>, 
	Pali Rohár <pali@...nel.org>, linux-omap@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: nokia n900: remove useless io-channel-cells
 property

Hi,

On Thu, Feb 13, 2025 at 09:32:03PM +0100, David Heidelberg wrote:
> This property is irrelevant for the ad5820 DAC,
> the driver nor the hardware indicate use of channel cells.
> 
> Fixes: d510d12f26f4 ("ARM: dts: nokia n900: update dts with camera support")
> Signed-off-by: David Heidelberg <david@...t.cz>
> ---

I certainly don't think this is a fix and probably just stay, see:

https://lore.kernel.org/all/ih3ykzxrnpbwg4bvkmpoo2tashcxidir4r4zofhlvrs7udkp7o@6qtqh6wtmkwd/

-- Sebastian

>  arch/arm/boot/dts/ti/omap/omap3-n900.dts | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git ./arch/arm/boot/dts/ti/omap/omap3-n900.dts ./arch/arm/boot/dts/ti/omap/omap3-n900.dts
> index 4bde3342bb959..c50ca572d1b9b 100644
> --- ./arch/arm/boot/dts/ti/omap/omap3-n900.dts
> +++ ./arch/arm/boot/dts/ti/omap/omap3-n900.dts
> @@ -816,8 +816,6 @@ ad5820: dac@c {
>  		reg = <0x0c>;
>  
>  		VANA-supply = <&vaux4>;
> -
> -		#io-channel-cells = <0>;
>  	};
>  };
>  
> -- 
> 2.47.2
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)