linux-kernel - Re: [PATCH 5/6] powerpc: powenv: oxcl: use lock guard for mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <324b4b5c6f1f0a777a217fdc05c8d01d4e0302ea.camel@linux.ibm.com>
Date: Wed, 19 Mar 2025 14:59:38 +1100
From: Andrew Donnellan <ajd@...ux.ibm.com>
To: Shrikanth Hegde <sshegde@...ux.ibm.com>
Cc: npiggin@...il.com, christophe.leroy@...roup.eu, mpe@...erman.id.au,
        peterz@...radead.org, fbarrat@...ux.ibm.com, mahesh@...ux.ibm.com,
        oohall@...il.com, hbathini@...ux.ibm.com, dhowells@...hat.com,
        haren@...ux.ibm.com, linux-kernel@...r.kernel.org, maddy@...ux.ibm.com,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 5/6] powerpc: powenv: oxcl: use lock guard for mutex

On Fri, 2025-03-14 at 15:00 +0530, Shrikanth Hegde wrote:
> 
> Hi. Andrew,
> 
> After this change below dev_dbg will be called with mutex held still.
> Is 
> that a concern? I don't see the mutex being used in that path.
> 
> Since using scoped_guard cause more code churn here, I would prefer
> not 
> use it.

I think this is fine.

-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@...ux.ibm.com   IBM Australia Limited