linux-kernel - Re: [PATCH] regulator: axp20x: AXP717: dcdc4 doesn't have delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGb2v65nJySARZJomSrfpiy1rQiETNUGWF1h6PDft=0Gru37SA@mail.gmail.com>
Date: Wed, 19 Mar 2025 12:44:45 +0800
From: Chen-Yu Tsai <wens@...e.org>
To: Philippe Simons <simons.philippe@...il.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, 
	linux-kernel@...r.kernel.org, Andre Przywara <andre.przywara@....com>
Subject: Re: [PATCH] regulator: axp20x: AXP717: dcdc4 doesn't have delay

On Wed, Mar 19, 2025 at 4:51 AM Philippe Simons
<simons.philippe@...il.com> wrote:
>
> According to AXP717 user manual, DCDC4 doesn't have a ramp delay like
> DCDC1/2/3 do.
>
> Remove it from the description and cleanup the macros.
>
> Signed-off-by: Philippe Simons <simons.philippe@...il.com>

Acked-by: Chen-Yu Tsai <wens@...e.org>

> ---
>  drivers/regulator/axp20x-regulator.c | 14 ++++----------
>  1 file changed, 4 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
> index dca99cfb7cbb..da891415efc0 100644
> --- a/drivers/regulator/axp20x-regulator.c
> +++ b/drivers/regulator/axp20x-regulator.c
> @@ -371,8 +371,8 @@
>                 .ops            = &axp20x_ops,                                  \
>         }
>
> -#define AXP_DESC_DELAY(_family, _id, _match, _supply, _min, _max, _step, _vreg,        \
> -                _vmask, _ereg, _emask, _ramp_delay)                            \
> +#define AXP_DESC(_family, _id, _match, _supply, _min, _max, _step, _vreg,      \
> +                _vmask, _ereg, _emask)                                         \
>         [_family##_##_id] = {                                                   \
>                 .name           = (_match),                                     \
>                 .supply_name    = (_supply),                                    \
> @@ -388,15 +388,9 @@
>                 .vsel_mask      = (_vmask),                                     \
>                 .enable_reg     = (_ereg),                                      \
>                 .enable_mask    = (_emask),                                     \
> -               .ramp_delay = (_ramp_delay),                                    \
>                 .ops            = &axp20x_ops,                                  \
>         }
>
> -#define AXP_DESC(_family, _id, _match, _supply, _min, _max, _step, _vreg,      \
> -                _vmask, _ereg, _emask)                                         \
> -       AXP_DESC_DELAY(_family, _id, _match, _supply, _min, _max, _step, _vreg, \
> -                _vmask, _ereg, _emask, 0)
> -
>  #define AXP_DESC_SW(_family, _id, _match, _supply, _ereg, _emask)              \
>         [_family##_##_id] = {                                                   \
>                 .name           = (_match),                                     \
> @@ -805,9 +799,9 @@ static const struct regulator_desc axp717_regulators[] = {
>                         axp717_dcdc3_ranges, AXP717_DCDC3_NUM_VOLTAGES,
>                         AXP717_DCDC3_CONTROL, AXP717_DCDC_V_OUT_MASK,
>                         AXP717_DCDC_OUTPUT_CONTROL, BIT(2), 640),
> -       AXP_DESC_DELAY(AXP717, DCDC4, "dcdc4", "vin4", 1000, 3700, 100,
> +       AXP_DESC(AXP717, DCDC4, "dcdc4", "vin4", 1000, 3700, 100,
>                  AXP717_DCDC4_CONTROL, AXP717_DCDC_V_OUT_MASK,
> -                AXP717_DCDC_OUTPUT_CONTROL, BIT(3), 6400),
> +                AXP717_DCDC_OUTPUT_CONTROL, BIT(3)),
>         AXP_DESC(AXP717, ALDO1, "aldo1", "aldoin", 500, 3500, 100,
>                  AXP717_ALDO1_CONTROL, AXP717_LDO_V_OUT_MASK,
>                  AXP717_LDO0_OUTPUT_CONTROL, BIT(0)),
> --
> 2.48.1
>