linux-kernel - Re: [PATCH v4 1/6 RESEND] platform/x86: Add lenovo-wmi-* driver Documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <33BD9018-8B34-4CCF-B026-8500EFF934CD@gmail.com>
Date: Tue, 18 Mar 2025 18:50:55 -1000
From: "Derek J. Clark" <derekjohn.clark@...il.com>
To: Bagas Sanjaya <bagasdotme@...il.com>, Hans de Goede <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
CC: Armin Wolf <W_Armin@....de>, Jonathan Corbet <corbet@....net>,
 Mario Limonciello <superm1@...nel.org>, Luke Jones <luke@...nes.dev>,
 Xino Ni <nijs1@...ovo.com>, Zhixin Zhang <zhangzx36@...ovo.com>,
 Mia Shao <shaohz1@...ovo.com>, Mark Pearson <mpearson-lenovo@...ebb.ca>,
 "Pierre-Loup A . Griffais" <pgriffais@...vesoftware.com>,
 "Cody T . -H . Chiu" <codyit@...il.com>, John Martens <johnfanv2@...il.com>,
 platform-driver-x86@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/6 RESEND] platform/x86: Add lenovo-wmi-* driver Documentation

On March 18, 2025 6:41:57 PM HST, Bagas Sanjaya <bagasdotme@...il.com> wrote:
>On Mon, Mar 17, 2025 at 07:43:21AM -0700, Derek J. Clark wrote:
>> +.. SPDX-License-Identifier: GPL-2.0-or-later
>> +==========================================================
>> +Lenovo WMI Interface Gamezone Driver (lenovo-wmi-gamezone)
>> +==========================================================
>><snipped>...
>> +.. SPDX-License-Identifier: GPL-2.0-or-later
>> +===========================================================
>> +Lenovo WMI Interface Other Mode Driver (lenovo-wmi-other)
>> +===========================================================
>
>I get htmldocs warnings due to SPDX line not being separated with title
>heading:
>
>Documentation/wmi/devices/lenovo-wmi-gamezone.rst:2: WARNING: Explicit markup ends without a blank line; unexpected unindent. [docutils]
>Documentation/wmi/devices/lenovo-wmi-other-method.rst:2: WARNING: Explicit markup ends without a blank line; unexpected unindent. [docutils]
>

Acked.

>> +The Other Mode WMI interface uses the firmware_attributes class to expose
>> +various WMI attributes provided by the interface in the sysfs. This enables
>> +CPU and GPU power limit tuning as well as various other attributes for
>> +devices that fall under the "Gaming Series" of Lenovo devices. Each
>> +attribute exposed by the Other Mode interface has corresponding
>> +capability data blocks which allow the driver to probe details about the
>> +attribute. Each attribute has multiple pages, one for each of the platform
>> +profiles managed by the Gamezone interface. Attributes are exposed in sysfs
>> +under the following path:
>> +
>> +::
>> +/sys/class/firmware-attributes/lenovo-wmi-other/attributes/<attribute>/
>
>sysfs path above isn't outputted as literal code block as it lacks indentation
>in the block text.
>
>Thanks.
>

Acked as well.

Thanks,
Derek