linux-kernel - Re: [PATCH v2] usb: cdns3: Fix deadlock when using NCM gadget

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250319055653.uSl-FEiQ@linutronix.de>
Date: Wed, 19 Mar 2025 06:56:53 +0100
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: Ralph Siemsen <ralph.siemsen@...aro.org>
Cc: Peter Chen <peter.chen@...nel.org>, Pawel Laszczak <pawell@...ence.com>,
	Roger Quadros <rogerq@...nel.org>,
	Aswath Govindraju <a-govindraju@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Felipe Balbi <felipe.balbi@...ux.intel.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-rt-devel@...ts.linux.dev,
	Thomas Gleixner <tglx@...utronix.de>,
	Steven Rostedt <rostedt@...dmis.org>, stable@...r.kernel.org
Subject: Re: [PATCH v2] usb: cdns3: Fix deadlock when using NCM gadget

On 2025-03-18 11:09:32 [-0400], Ralph Siemsen wrote:
> The cdns3 driver has the same NCM deadlock as fixed in cdnsp by commit
> 58f2fcb3a845 ("usb: cdnsp: Fix deadlock issue during using NCM gadget").
> 
> Under PREEMPT_RT the deadlock can be readily triggered by heavy network
> traffic, for example using "iperf --bidir" over NCM ethernet link.
> 
> The deadlock occurs because the threaded interrupt handler gets
> preempted by a softirq, but both are protected by the same spinlock.
> Prevent deadlock by disabling softirq during threaded irq handler.
> 
> cc: stable@...r.kernel.org
> Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
> Signed-off-by: Ralph Siemsen <ralph.siemsen@...aro.org>

Reviewed-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

Sebastian