linux-kernel - Re: [PATCH] mm/hugetlb: move hugetlb_sysctl_init() to the _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c03fbda6-4465-4ada-a9eb-d02893f509d4@arm.com>
Date: Wed, 19 Mar 2025 11:57:49 +0530
From: Anshuman Khandual <anshuman.khandual@....com>
To: marc.herbert@...ux.intel.com
Cc: Muchun Song <muchun.song@...ux.dev>,
 Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/hugetlb: move hugetlb_sysctl_init() to the __init
 section


On 3/19/25 11:30, marc.herbert@...ux.intel.com wrote:
> From: Marc Herbert <Marc.Herbert@...ux.intel.com>
> 
> hugetlb_sysctl_init() is only invoked once by an __init function and is
> merely a wrapper around another __init function so there is not reason
> to keep it.
> 
> Fixes the following warning when toning down some GCC inline options:
> 
>  WARNING: modpost: vmlinux: section mismatch in reference:
>    hugetlb_sysctl_init+0x1b (section: .text) ->
>      __register_sysctl_init (section: .init.text)
> 
> Signed-off-by: Marc Herbert <Marc.Herbert@...ux.intel.com>
> ---
>  mm/hugetlb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 65068671e460..a2850b26aed9 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -4900,7 +4900,7 @@ static const struct ctl_table hugetlb_table[] = {
>  	},
>  };
>  
> -static void hugetlb_sysctl_init(void)
> +static void __init hugetlb_sysctl_init(void)
>  {
>  	register_sysctl_init("vm", hugetlb_table);
>  }

LGTM

Reviewed-by: Anshuman Khandual <anshuman.khandual@....com>