linux-kernel - Re: [PATCH v4 1/2] dt-bindings: iio: light: bh1750: Add reset-gpios property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250319-elated-illegal-griffin-4ff0aa@krzk-bin>
Date: Wed, 19 Mar 2025 09:42:32 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sergio Perez <sergio@...eznus.es>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org, 
	Tomasz Duszynski <tduszyns@...il.com>, Jonathan Cameron <jic23@...nel.org>, 
	Lars-Peter Clausen <lars@...afoo.de>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: iio: light: bh1750: Add reset-gpios
 property

On Tue, Mar 18, 2025 at 08:45:54PM +0100, Sergio Perez wrote:

Your threading is completely broken.

Read my last message - I gave you clear instructions which you did not
follow. Why?

>  
> +  reset-gpios:
> +    description: GPIO connected to the sensor's reset line (active low)

"Active low reset line". No point to say that GPIO is a "GPIO connected
to the...", because it cannot be anything else.

> +    maxItems: 1
> +
>  required:
>    - compatible
>    - reg
> @@ -39,6 +43,7 @@ examples:
>        light-sensor@23 {
>          compatible = "rohm,bh1750";
>          reg = <0x23>;
> +        reset-gpios = <&gpio2 17 0>;

1. Include header and use proper defines
2. And then you will see that it is not active low, like you claim in
description...

>        };
>      };
>  
> -- 
> 2.43.0
>