linux-kernel - Re: [PATCH] MIPS: cm: Fix warning if MIPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9qNQA_uyLG8bToX@alpha.franken.de>
Date: Wed, 19 Mar 2025 10:24:16 +0100
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: Gregory CLEMENT <gregory.clement@...tlin.com>,
	linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: cm: Fix warning if MIPS_CM is disabled

On Fri, Feb 28, 2025 at 03:37:02PM +0100, Thomas Bogendoerfer wrote:
> Commit e27fbe16af5c ("MIPS: cm: Detect CM quirks from device tree")
> introduced
> 
> arch/mips/include/asm/mips-cm.h:119:13: error: ‘mips_cm_update_property’
> 	defined but not used [-Werror=unused-function]
> 
> Fix this by making empty function implementation inline
> 
> Fixes: e27fbe16af5c ("MIPS: cm: Detect CM quirks from device tree")
> Signed-off-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> ---
>  arch/mips/include/asm/mips-cm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/include/asm/mips-cm.h b/arch/mips/include/asm/mips-cm.h
> index 3bfe0633b576..407f253bb4a1 100644
> --- a/arch/mips/include/asm/mips-cm.h
> +++ b/arch/mips/include/asm/mips-cm.h
> @@ -116,7 +116,7 @@ static inline bool mips_cm_present(void)
>  #ifdef CONFIG_MIPS_CM
>  extern void mips_cm_update_property(void);
>  #else
> -static void mips_cm_update_property(void) {}
> +static inline void mips_cm_update_property(void) {}
>  #endif
>  
>  /**
> -- 
> 2.35.3

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]