Message-ID: <CAHp75VfJPgaGyERBaSxSGap+Daeuy8kOjyjg+QkCtzxUydzHiQ@mail.gmail.com>
Date: Wed, 19 Mar 2025 12:21:53 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
Cc: tglx@...utronix.de, maz@...nel.org, linux-kernel@...r.kernel.org, 
	Aaro Koskinen <aaro.koskinen@....fi>, Abhinav Kumar <quic_abhinavk@...cinc.com>, 
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Belloni <alexandre.belloni@...tlin.com>, 
	Alexandre Ghiti <alex@...ti.fr>, Alexandre Torgue <alexandre.torgue@...s.st.com>, 
	Alex Deucher <alexander.deucher@....com>, Alex Shi <alexs@...nel.org>, 
	Alim Akhtar <alim.akhtar@...sung.com>, Alvin Šipraga <alsi@...g-olufsen.dk>, 
	Alyssa Rosenzweig <alyssa@...enzweig.io>, amd-gfx@...ts.freedesktop.org, 
	Amit Kucheria <amitk@...nel.org>, Anatolij Gustschin <agust@...x.de>, Andi Shyti <andi.shyti@...nel.org>, 
	Andreas Färber <afaerber@...e.de>, 
	Andreas Kemnade <andreas@...nade.info>, Andrew Jeffery <andrew@...econstruct.com.au>, 
	Andrew Lunn <andrew@...n.ch>, Andy Shevchenko <andy@...nel.org>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
	Antoine Tenart <atenart@...nel.org>, Anton Ivanov <anton.ivanov@...bridgegreys.com>, 
	Anup Patel <anup@...infault.org>, Arnd Bergmann <arnd@...db.de>, asahi@...ts.linux.dev, 
	Bartosz Golaszewski <brgl@...ev.pl>, Baruch Siach <baruch@...s.co.il>, 
	Benjamin Herrenschmidt <benh@...nel.crashing.org>, 
	Bharat Kumar Gogada <bharat.kumar.gogada@....com>, Bjorn Andersson <andersson@...nel.org>, 
	Bjorn Helgaas <bhelgaas@...gle.com>, Borislav Petkov <bp@...en8.de>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, 
	Claudiu Beznea <claudiu.beznea@...on.dev>, Corentin Chary <corentin.chary@...il.com>, 
	Daire McNamara <daire.mcnamara@...rochip.com>, Daniel Golle <daniel@...rotopia.org>, 
	Daniel Lezcano <daniel.lezcano@...aro.org>, Daniel Mack <daniel@...que.org>, 
	Daniel Palmer <daniel@...ngy.jp>, Dave Hansen <dave.hansen@...ux.intel.com>, 
	David Airlie <airlied@...il.com>, "David S. Miller" <davem@...emloft.net>, 
	DENG Qingfang <dqfext@...il.com>, Dinh Nguyen <dinguyen@...nel.org>, 
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, Dongliang Mu <dzm91@...t.edu.cn>, 
	Doug Berger <opendmb@...il.com>, dri-devel@...ts.freedesktop.org, 
	Eddie James <eajames@...ux.ibm.com>, Eric Dumazet <edumazet@...gle.com>, 
	Fabio Estevam <festevam@...il.com>, Florian Fainelli <florian.fainelli@...adcom.com>, 
	Geoff Levand <geoff@...radead.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Gregory Clement <gregory.clement@...tlin.com>, Guo Ren <guoren@...nel.org>, 
	Hans de Goede <hdegoede@...hat.com>, Haojian Zhuang <haojian.zhuang@...il.com>, 
	Haojian Zhuang <haojian.zhuang@...aro.org>, Heiko Stuebner <heiko@...ech.de>, 
	Herve Codina <herve.codina@...tlin.com>, Hou Zhiqiang <Zhiqiang.Hou@....com>, 
	"H. Peter Anvin" <hpa@...or.com>, Huacai Chen <chenhuacai@...nel.org>, 
	Changhuang Liang <changhuang.liang@...rfivetech.com>, Chen-Yu Tsai <wens@...e.org>, 
	"Chester A. Unal" <chester.a.unal@...nc9.com>, Christian König <christian.koenig@....com>, 
	Christophe Leroy <christophe.leroy@...roup.eu>, Chris Zankel <chris@...kel.net>, 
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, 
	Imre Kaloz <kaloz@...nwrt.org>, Ingo Molnar <mingo@...hat.com>, Jakub Kicinski <kuba@...nel.org>, 
	James Morse <james.morse@....com>, Janne Grunau <j@...nau.net>, 
	Janusz Krzysztofik <jmkrzyszt@...il.com>, Jaroslav Kysela <perex@...ex.cz>, 
	Jassi Brar <jassisinghbrar@...il.com>, Jernej Skrabec <jernej.skrabec@...il.com>, 
	Jerome Brunet <jbrunet@...libre.com>, Jianjun Wang <jianjun.wang@...iatek.com>, 
	Jiawen Wu <jiawenwu@...stnetic.com>, Jiaxun Yang <jiaxun.yang@...goat.com>, 
	Jim Quinlan <jim2101024@...il.com>, Jingoo Han <jingoohan1@...il.com>, 
	Joel Stanley <joel@....id.au>, Johannes Berg <johannes@...solutions.net>, 
	John Crispin <john@...ozen.org>, John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>, 
	Jonas Bonn <jonas@...thpole.se>, Jonathan Cameron <jic23@...nel.org>, Jonathan Corbet <corbet@....net>, 
	Jonathan Hunter <jonathanh@...dia.com>, Jonathan Neuschäfer <j.neuschaefer@....net>, 
	Joyce Ooi <joyce.ooi@...el.com>, Karthikeyan Mitran <m.karthikeyan@...iveil.co.in>, 
	Keerthy <j-keerthy@...com>, Kevin Hilman <khilman@...libre.com>, 
	Konrad Dybcio <konradybcio@...nel.org>, Krzysztof Kozlowski <krzk@...nel.org>, 
	Krzysztof Wilczyński <kw@...ux.com>, 
	Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>, 
	Lakshmi Sowjanya D <lakshmi.sowjanya.d@...el.com>, Lars-Peter Clausen <lars@...afoo.de>, 
	Lee Jones <lee@...nel.org>, Liam Girdwood <lgirdwood@...il.com>, 
	Linus Walleij <linus.walleij@...aro.org>, Linus Walleij <linusw@...nel.org>, 
	linux-amlogic@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, 
	linux-arm-msm@...r.kernel.org, linux-doc@...r.kernel.org, 
	linux-edac@...r.kernel.org, linux-gpio@...r.kernel.org, 
	linux-iio@...r.kernel.org, linux-i2c@...r.kernel.org, 
	linux-mediatek@...ts.infradead.org, linux-mips@...r.kernel.org, 
	linux-omap@...r.kernel.org, linux-pci@...r.kernel.org, 
	linuxppc-dev@...ts.ozlabs.org, linux-remoteproc@...r.kernel.org, 
	linux-riscv@...ts.infradead.org, linux-rpi-kernel@...ts.infradead.org, 
	linux-sh@...r.kernel.org, linux-snps-arc@...ts.infradead.org, 
	linux-sound@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, 
	linux-um@...ts.infradead.org, linux-wireless@...r.kernel.org, 
	loongarch@...ts.linux.dev, Lorenzo Pieralisi <lpieralisi@...nel.org>, 
	Ludovic Desroches <ludovic.desroches@...rochip.com>, Lukasz Luba <lukasz.luba@....com>, 
	"Luke D. Jones" <luke@...nes.dev>, Madhavan Srinivasan <maddy@...ux.ibm.com>, 
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, Marek Behún <kabel@...nel.org>, 
	Marijn Suijten <marijn.suijten@...ainline.org>, Mark Brown <broonie@...nel.org>, 
	Mark-PK Tsai <mark-pk.tsai@...iatek.com>, 
	Martin Blumenstingl <martin.blumenstingl@...glemail.com>, Masami Hiramatsu <mhiramat@...nel.org>, 
	Mathieu Poirier <mathieu.poirier@...aro.org>, Matthias Brugger <matthias.bgg@...il.com>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Max Filippov <jcmvbkbc@...il.com>, 
	Maxime Coquelin <mcoquelin.stm32@...il.com>, Mengyuan Lou <mengyuanlou@...-swift.com>, 
	Michael Buesch <m@...s.ch>, Michael Ellerman <mpe@...erman.id.au>, Michal Simek <michal.simek@....com>, 
	Miodrag Dinic <miodrag.dinic@...s.com>, Naveen N Rao <naveen@...nel.org>, 
	Neil Armstrong <neil.armstrong@...aro.org>, netdev@...r.kernel.org, 
	Nicolas Ferre <nicolas.ferre@...rochip.com>, Nicolas Saenz Julienne <nsaenz@...nel.org>, 
	Nicholas Piggin <npiggin@...il.com>, Nikhil Agarwal <nikhil.agarwal@....com>, 
	Nipun Gupta <nipun.gupta@....com>, Nishanth Menon <nm@...com>, Pali Rohár <pali@...nel.org>, 
	Palmer Dabbelt <palmer@...belt.com>, Paolo Abeni <pabeni@...hat.com>, 
	Paul Cercueil <paul@...pouillou.net>, Paul Walmsley <paul.walmsley@...ive.com>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, Peter Rosin <peda@...ntia.se>, 
	Philipp Zabel <p.zabel@...gutronix.de>, Piotr Wojtaszczyk <piotr.wojtaszczyk@...esys.com>, 
	platform-driver-x86@...r.kernel.org, 
	Prasad Kumpatla <quic_pkumpatl@...cinc.com>, Qiang Zhao <qiang.zhao@....com>, 
	Qin Jian <qinjian@...lus1.com>, "Rafael J. Wysocki" <rafael@...nel.org>, 
	Randy Dunlap <rdunlap@...radead.org>, Ray Jui <rjui@...adcom.com>, 
	Rengarajan Sundararajan <Rengarajan.S@...rochip.com>, Richard Cochran <richardcochran@...il.com>, 
	Richard Weinberger <richard@....at>, Rich Felker <dalias@...c.org>, Rob Clark <robdclark@...il.com>, 
	Robert Jarzmik <robert.jarzmik@...e.fr>, Robert Richter <rric@...nel.org>, Rob Herring <robh@...nel.org>, 
	Roger Quadros <rogerq@...nel.org>, Russell King <linux@...linux.org.uk>, 
	Ryan Chen <ryan_chen@...eedtech.com>, Ryder Lee <ryder.lee@...iatek.com>, 
	Samuel Holland <samuel@...lland.org>, Santosh Shilimkar <ssantosh@...nel.org>, 
	Sascha Hauer <s.hauer@...gutronix.de>, Scott Branden <sbranden@...adcom.com>, 
	Scott Wood <oss@...error.net>, Sean Paul <sean@...rly.run>, Sean Wang <sean.wang@...nel.org>, 
	Sean Wang <sean.wang@...iatek.com>, 
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>, 
	Sergio Paracuellos <sergio.paracuellos@...il.com>, Shawn Guo <shawnguo@...nel.org>, 
	Shawn Lin <shawn.lin@...k-chips.com>, Siddharth Vadapalli <s-vadapalli@...com>, 
	Simona Vetter <simona@...ll.ch>, Stafford Horne <shorne@...il.com>, 
	Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>, Stephen Boyd <sboyd@...nel.org>, 
	Sven Peter <sven@...npeter.dev>, Takashi Iwai <tiwai@...e.com>, Talel Shenhar <talel@...zon.com>, 
	Tero Kristo <kristo@...nel.org>, Thangaraj Samynathan <Thangaraj.S@...rochip.com>, 
	Thara Gopinath <thara.gopinath@...il.com>, Thierry Reding <thierry.reding@...il.com>, 
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
	Toan Le <toan@...amperecomputing.com>, Tony Lindgren <tony@...mide.com>, 
	Tony Luck <tony.luck@...el.com>, UNGLinuxDriver@...rochip.com, 
	Uwe Kleine-König <ukleinek@...nel.org>, 
	Vignesh Raghavendra <vigneshr@...com>, Vineet Gupta <vgupta@...nel.org>, Vladimir Oltean <olteanv@...il.com>, 
	Vladimir Zapolskiy <vz@...ia.com>, WANG Xuerui <kernel@...0n.name>, 
	Woojung Huh <woojung.huh@...rochip.com>, x86@...nel.org, 
	Yanteng Si <si.yanteng@...ux.dev>, Yoshinori Sato <ysato@...rs.sourceforge.jp>, 
	Zhang Rui <rui.zhang@...el.com>
Subject: Re: [PATCH v2 00/57] irqdomain: Cleanups and Documentation

On Wed, Mar 19, 2025 at 11:30 AM Jiri Slaby (SUSE) <jirislaby@...nel.org> wrote:
>
> Hi,
>
> tl;dr if patches are agreed upon, I ask subsys maintainers to take the
> respective ones via their trees (as they are split per subsys), so that
> the IRQ tree can take only the rest. That would minimize churn/conflicts
> during merges.
>
> ===
>
> While I was reading through the irqdomain code and headers, I found some
> naming and documentation hard to follow or incomplete. Especially the
> naming of _add/_create/_instantiate functions.
>
> I tried to come up with a better state with this patchset:
> * only irq _domain_ (not host),
> * only irq_domain_create*() functions, all taking fwnode uniformly,
>
> Finally, all the irqdomain stuff is now plugged (and generated) into
> Documentation. So that everyone can walk through it at
> https://www.kernel.org/doc/ (once applied, of course).

I am all to support the idea, but in some cases I would think of a bit
more work to be done to get rid of the of_fwnode_handle(np) in favour
of dev_fwnode(dev). Note, this is based on a brief look, I haven't any
example at hand right now.

-- 
With Best Regards,
Andy Shevchenko

Powered by blists - more mailing lists