linux-kernel - Re: [PATCH net] wifi: ath12k: properly set single_chip_mlo_supp to true in ath12k_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91a5a1f7-6eef-4ea0-bcde-350640984a7b@kernel.org>
Date: Wed, 19 Mar 2025 11:29:18 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Baochen Qiang <quic_bqiang@...cinc.com>, neil.armstrong@...aro.org,
 Vasanthakumar Thiagarajan <quic_vthiagar@...cinc.com>,
 Jeff Johnson <jeff.johnson@....qualcomm.com>,
 Johannes Berg <johannes@...solutions.net>, Jeff Johnson
 <jjohnson@...nel.org>, Aditya Kumar Singh <quic_adisi@...cinc.com>
Cc: linux-wireless@...r.kernel.org, ath12k@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH net] wifi: ath12k: properly set single_chip_mlo_supp to
 true in ath12k_core_alloc()

On 19/03/2025 10:46, Baochen Qiang wrote:
> 
> 
> On 3/19/2025 5:12 PM, neil.armstrong@...aro.org wrote:
>> Hi,
>>
>> On 19/03/2025 10:06, Vasanthakumar Thiagarajan wrote:
>>>
>>>
>>> On 3/19/2025 1:34 PM, Neil Armstrong wrote:
>>>> On 18/03/2025 17:35, Jeff Johnson wrote:
>>>>> On 3/3/2025 7:00 AM, Neil Armstrong wrote:
>>>>>> In commit 46d16f7e1d14 ("wifi: ath12k: rename mlo_capable_flags to
>>>>>> single_chip_mlo_supp")
>>>>>> the line:
>>>>>>     ab->mlo_capable_flags = ATH12K_INTRA_DEVICE_MLO_SUPPORT;
>>>>>> was incorrectly updated to:
>>>>>>     ab->single_chip_mlo_supp = false;
>>>>>> leading to always disabling INTRA_DEVICE_MLO even if the device supports it.
>>>>>>
>>>>>> The firmware "WLAN.HMT.1.1.c5-00156-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1"
>>>>>> crashes on driver initialization with:
>>>>>>   ath12k_pci 0000:01:00.0: chip_id 0x2 chip_family 0x4 board_id 0x3d soc_id 0x40170200
>>>>>>   ath12k_pci 0000:01:00.0: fw_version 0x110f009c fw_build_timestamp 2024-05-30 11:35
>>>>>> fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HMT.1.1.c5-00156-
>>>>>> QCAHMTSWPL_V1.0_V2.0_SILICONZ-1
> 
> this FW version is not upstream yet, why are you testing with it?
> 
> Generally we only support upstrmea driver + upstream FW.
FW does not have to be upstream. We work, here in upstream, with all
sort of vendors and all sorts of devices, for which vendors might not
send yet their FW or we are unclear about licensing rules.

Regression is still regression and stop deflecting the discussion -
third response now! - what you internally want to achieve.

Upstream does not care about your internal processes.


Best regards,
Krzysztof