linux-kernel - Re: [PATCH v2 17/57] irqdomain: gpio: Switch to irq_domain_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z9qfIQ2TEhkgLT2Q@smile.fi.intel.com>
Date: Wed, 19 Mar 2025 12:40:33 +0200
From: Andy Shevchenko <andy@...nel.org>
To: "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
Cc: tglx@...utronix.de, maz@...nel.org, linux-kernel@...r.kernel.org,
	Doug Berger <opendmb@...il.com>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>, Keerthy <j-keerthy@...com>,
	Vladimir Zapolskiy <vz@...ia.com>,
	Uwe Kleine-König <ukleinek@...nel.org>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Heiko Stuebner <heiko@...ech.de>, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v2 17/57] irqdomain: gpio: Switch to irq_domain_create_*()

On Wed, Mar 19, 2025 at 10:29:10AM +0100, Jiri Slaby (SUSE) wrote:
> irq_domain_add_*() interfaces are going away as being obsolete now.
> Switch to the preferred irq_domain_create_*() ones. Those differ in the
> node parameter: They take more generic struct fwnode_handle instead of
> struct device_node. Therefore, of_fwnode_handle() is added around the
> original parameter.
> 
> Note some of the users can likely use dev->fwnode directly instead of
> indirect of_fwnode_handle(dev->of_node). But dev->fwnode is not
> guaranteed to be set for all, so this has to be investigated on case to
> case basis (by people who can actually test with the HW).

...

>  	/**
>  	 * @first:
>  	 *
> -	 * Required for static IRQ allocation. If set, irq_domain_add_simple()

> -	 * will allocate and map all IRQs during initialization.

Can we leave this untouched? The new name will make the string 81 characters
long and I don't think we care about that, on the pros side it will reduce
a churn in this patch.

> +	 * Required for static IRQ allocation. If set,
> +	 * irq_domain_create_simple() will allocate and map all IRQs
> +	 * during initialization.
>  	 */

-- 
With Best Regards,
Andy Shevchenko