linux-kernel - Re: [PATCH v2 3/3] kernel/events/uprobes: uprobe_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d0f0cbb3-6284-4060-afdb-ea828b9e909d@redhat.com>
Date: Wed, 19 Mar 2025 13:02:50 +0100
From: David Hildenbrand <david@...hat.com>
To: Oleg Nesterov <oleg@...hat.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org,
 linux-arm-kernel@...ts.infradead.org, linux-trace-kernel@...r.kernel.org,
 linux-perf-users@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>,
 Andrii Nakryiko <andrii.nakryiko@...il.com>,
 Matthew Wilcox <willy@...radead.org>, Russell King <linux@...linux.org.uk>,
 Masami Hiramatsu <mhiramat@...nel.org>, Peter Zijlstra
 <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Arnaldo Carvalho de Melo <acme@...nel.org>,
 Namhyung Kim <namhyung@...nel.org>, Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
 Adrian Hunter <adrian.hunter@...el.com>,
 "Liang, Kan" <kan.liang@...ux.intel.com>,
 Tong Tiangen <tongtiangen@...wei.com>
Subject: Re: [PATCH v2 3/3] kernel/events/uprobes: uprobe_write_opcode()
 rewrite

On 19.03.25 13:00, Oleg Nesterov wrote:
> On 03/18, David Hildenbrand wrote:
>>
>> +	if (unlikely(!folio_test_anon(folio))) {
>> +		VM_WARN_ON_ONCE(is_register);
>> +		goto out;
>> +	}
> 
> Don't we need folio_put() before "goto out" ?
> 

Yes, thanks! ... as always, the result of some last-minute reshuffling :)

> Other than that, for this series:
> 
> Acked-by: Oleg Nesterov <oleg@...hat.com>
> 


-- 
Cheers,

David / dhildenb