linux-kernel - Re: [PATCH] iio: dac: ad3552r-hs: add debugfs reg access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <83ee5dd5c427355b38c1c5a63cdae4a114acd1ce.camel@gmail.com>
Date: Wed, 19 Mar 2025 12:11:03 +0000
From: Nuno Sá <noname.nuno@...il.com>
To: Angelo Dureghello <adureghello@...libre.com>, Lars-Peter Clausen
	 <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, 
 Jonathan Cameron
	 <jic23@...nel.org>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: dac: ad3552r-hs: add debugfs reg access

On Wed, 2025-03-19 at 12:02 +0100, Angelo Dureghello wrote:
> From: Angelo Dureghello <adureghello@...libre.com>
> 
> Add debugfs register access.
> 
> Signed-off-by: Angelo Dureghello <adureghello@...libre.com>
> ---

Minor nit you might consider to change if a v2 is needed for some reason...

Reviewed-by: Nuno Sá <nuno.sa@...log.com>

>  drivers/iio/dac/ad3552r-hs.c | 31 +++++++++++++++++++++++++++++++
>  drivers/iio/dac/ad3552r.h    |  2 ++
>  2 files changed, 33 insertions(+)
> 
> diff --git a/drivers/iio/dac/ad3552r-hs.c b/drivers/iio/dac/ad3552r-hs.c
> index
> cd8dabb60c5548780f0fce5d1b68c494cd71321d..7bb6d8817a545f16de9432526ae28787af1a
> 0146 100644
> --- a/drivers/iio/dac/ad3552r-hs.c
> +++ b/drivers/iio/dac/ad3552r-hs.c
> @@ -7,6 +7,7 @@
>   */
>  
>  #include <linux/bitfield.h>
> +#include <linux/debugfs.h>
>  #include <linux/delay.h>
>  #include <linux/gpio/consumer.h>
>  #include <linux/iio/backend.h>
> @@ -56,6 +57,15 @@ struct ad3552r_hs_state {
>  	u32 config_d;
>  };
>  
> +static int ad3552r_hs_get_reg_length(unsigned int reg)
> +{
> +	/*
> +	 * There is no 3 or 4 bytes r/w len possible in HDL, so keeping 2
> +	 * also for the 24bit area.
> +	 */
> +	return (reg > AD3552R_SECONDARY_REGION_START) ? 2 : 1;
> +}
> +

I wonder about the added value of the above. Since it's really only used once, I
would do it inline