linux-kernel - Re: [PATCH] serial: 8250_dma: terminate correct DMA in tx_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c452c05a-b6ad-144a-2738-ba52d57e7eef@linux.intel.com>
Date: Wed, 19 Mar 2025 14:21:39 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: John Keeping <jkeeping@...usicbrands.com>
cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
    Wentao Guan <guanwentao@...ontech.com>, Jiri Slaby <jirislaby@...nel.org>, 
    Ferry Toth <ftoth@...londelft.nl>, 
    Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, 
    LKML <linux-kernel@...r.kernel.org>, 
    linux-serial <linux-serial@...r.kernel.org>
Subject: Re: [PATCH] serial: 8250_dma: terminate correct DMA in
 tx_dma_flush()

On Mon, 24 Feb 2025, John Keeping wrote:

> When flushing transmit side DMA, it is the transmit channel that should
> be terminated, not the receive channel.
> 
> Fixes: 9e512eaaf8f40 ("serial: 8250: Fix fifo underflow on flush")
> Reported-by: Wentao Guan <guanwentao@...ontech.com>
> Signed-off-by: John Keeping <jkeeping@...usicbrands.com>
> ---
>  drivers/tty/serial/8250/8250_dma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_dma.c b/drivers/tty/serial/8250/8250_dma.c
> index f245a84f4a508..bdd26c9f34bdf 100644
> --- a/drivers/tty/serial/8250/8250_dma.c
> +++ b/drivers/tty/serial/8250/8250_dma.c
> @@ -162,7 +162,7 @@ void serial8250_tx_dma_flush(struct uart_8250_port *p)
>  	 */
>  	dma->tx_size = 0;
>  
> -	dmaengine_terminate_async(dma->rxchan);
> +	dmaengine_terminate_async(dma->txchan);
>  }
>  
>  int serial8250_rx_dma(struct uart_8250_port *p)
> 

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.