linux-kernel - Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3e28dc9eb03e2269e2c4613d415291cbda99dfad.camel@linux.ibm.com>
Date: Thu, 20 Mar 2025 18:19:38 +0100
From: Maximilian Immanuel Brandtner <maxbr@...ux.ibm.com>
To: Halil Pasic <pasic@...ux.ibm.com>
Cc: "Michael S. Tsirkin" <mst@...hat.com>, Amit Shah <amit@...nel.org>,
        linux-kernel@...r.kernel.org, virtualization@...ts.linux.dev,
        arnd@...db.de, gregkh@...uxfoundation.org, brueckner@...ux.ibm.com,
        schnelle@...ux.ibm.com
Subject: Re: [PATCH] virtio: console: Make resizing compliant with virtio
 spec

On Thu, 2025-03-20 at 15:19 +0100, Halil Pasic wrote:
> On Thu, 20 Mar 2025 15:09:57 +0100
> Halil Pasic <pasic@...ux.ibm.com> wrote:
> 
> > > I already implemented it in my patch v2 (just waiting for Amit to
> > > confirm the new commit message). But if you want to split it you
> > > can
> > > create a seperate patch for it as well (I don't really mind
> > > either
> > > way).
> > >   
> 
> Your v2 has not been posted yet, or? I can't find it in my Inbox.
> 
> I understand that you have confirmed that the byte order handling is
> needed but missing, right?

Yes, I wanted to first hear back from Amit whether he liked the new
commit message, but seeing as he hasn't yet replied I'll just post it
now. I've confirmed that the endianness handling is necessary, but not
implementated. I've looked all the way down into hvc_console() up until
tty_do_resize(), but there are no endianess adjustments up until that
point aka I'm pretty certain the endianness is broken.

I'll post my v2 without the endianness fix then

> 
> > 
> > It is conceptually a different bug and warrants a patch and a
> > commit
> > message of its own. At least IMHO.