linux-kernel - Re: [PATCH] kunit: cs_dsp: Depend on FW_CS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAA1CXcA460xfy48JMNeX5rNTfUqsahER8SDF6tWu82V35ripLg@mail.gmail.com>
Date: Thu, 20 Mar 2025 11:33:54 -0600
From: Nico Pache <npache@...hat.com>
To: Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc: broonie@...nel.org, patches@...nsource.cirrus.com, 
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	kunit-dev@...glegroups.com, simont@...nsource.cirrus.com, 
	ckeepax@...nsource.cirrus.com, brendan.higgins@...ux.dev, davidgow@...gle.com, 
	rmoar@...gle.com, johannes.berg@...el.com, sj@...nel.org
Subject: Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

On Thu, Mar 20, 2025 at 6:21 AM Richard Fitzgerald
<rf@...nsource.cirrus.com> wrote:
>
> On 19/3/25 23:11, Nico Pache wrote:
> > On Wed, Mar 19, 2025 at 5:05 PM Nico Pache <npache@...hat.com> wrote:
> >>
> >> FW_CS_DSP gets enabled if KUNIT is enabled. The test should rather
> >> depend on if the feature is enabled. Fix this by moving FW_CS_DSP to the
> >> depends on clause, and set CONFIG_FW_CS_DSP=y in the kunit tooling.
> >
> > A further note here:
> >
> > This test is failing and panicing across multiple arches, and
> > triggering kasan slats on debug kernels. I think this test needs more
> > testing ;P
> >
>
> Please supply details of failures or links to bug reports.
> "is failing" and "panicing" doesn't tell me enough to fix anything.
> Failing how? Panicking how? On what architectures?
> I tested it on the architectures I have available, and the kunit um
> architecture. Unfortunately not everyone has hardware for every
> architecture supported by Linux so we have to trust somewhat that
> other architectures don't do anything unexpectedly different from
> what we _can_ test it on.

Some of the runs return not ok on a bunch of tests, debug kernels
print splats, and some seem to brick the system, leading to a reboot.
Below are all the failures per arch/variant.

Failing on
---------------------
X86_64 : https://s3.amazonaws.com/arr-cki-prod-trusted-artifacts/trusted-artifacts/1723153780/test_x86_64/9451298630/artifacts/run.done.01/job.01/recipes/18353773/tasks/7/results/1742341634/logs/resultoutputfile.log
X86_64 (debug) :
https://s3.amazonaws.com/arr-cki-prod-trusted-artifacts/trusted-artifacts/1717840829/test_x86_64/9419724200/artifacts/run.done.01/results_0001/console.log

aarch64 : https://s3.amazonaws.com/arr-cki-prod-trusted-artifacts/trusted-artifacts/1723153780/test_aarch64/9451298664/artifacts/run.done.01/job.01/recipes/18352965/tasks/7/results/1742330044/logs/resultoutputfile.log
aarch64(debug):
https://s3.amazonaws.com/arr-cki-prod-trusted-artifacts/trusted-artifacts/1717840829/test_aarch64/9419724214/artifacts/run.done.01/results_0001/console.log
aarch64-64kpagesize:
https://s3.amazonaws.com/arr-cki-prod-trusted-artifacts/trusted-artifacts/1723154540/test_aarch64/9451303359/artifacts/run.done.01/job.01/recipes/18352963/tasks/7/results/1742331192/logs/resultoutputfile.log
aarch64-64kpagesize (debug):
https://s3.amazonaws.com/arr-cki-prod-trusted-artifacts/trusted-artifacts/1723154644/test_aarch64/9451304808/artifacts/run.done.01/job.01/recipes/18354911/tasks/6/results/1742356729/logs/resultoutputfile.log

ppc64le: https://s3.amazonaws.com/arr-cki-prod-trusted-artifacts/trusted-artifacts/1723153780/test_ppc64le/9451298644/artifacts/run.done.01/results_0001/console.log
ppc64le(debug):
https://s3.amazonaws.com/arr-cki-prod-trusted-artifacts/trusted-artifacts/1717840829/test_ppc64le/9419724210/artifacts/run.done.01/results_0001/console.log

>
> Also, are any of these failures the unterminated string bug that someone
> fixed recently?
Not sure. That fix doesn't seem to have been merged yet.
>
> >>
> >> Fixes: dd0b6b1f29b9 ("firmware: cs_dsp: Add KUnit testing of bin file download")
> >> Signed-off-by: Nico Pache <npache@...hat.com>
> >> ---
> >>   drivers/firmware/cirrus/Kconfig              | 3 +--
> >>   tools/testing/kunit/configs/all_tests.config | 2 ++
> >>   2 files changed, 3 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/firmware/cirrus/Kconfig b/drivers/firmware/cirrus/Kconfig
> >> index 0a883091259a..989568ab5712 100644
> >> --- a/drivers/firmware/cirrus/Kconfig
> >> +++ b/drivers/firmware/cirrus/Kconfig
> >> @@ -11,9 +11,8 @@ config FW_CS_DSP_KUNIT_TEST_UTILS
> >>
> >>   config FW_CS_DSP_KUNIT_TEST
> >>          tristate "KUnit tests for Cirrus Logic cs_dsp" if !KUNIT_ALL_TESTS
> >> -       depends on KUNIT && REGMAP
> >> +       depends on KUNIT && REGMAP && FW_CS_DSP
> >>          default KUNIT_ALL_TESTS
> >> -       select FW_CS_DSP
> >>          select FW_CS_DSP_KUNIT_TEST_UTILS
> >>          help
> >>            This builds KUnit tests for cs_dsp.
> >> diff --git a/tools/testing/kunit/configs/all_tests.config b/tools/testing/kunit/configs/all_tests.config
> >> index b0049be00c70..96c6b4aca87d 100644
> >> --- a/tools/testing/kunit/configs/all_tests.config
> >> +++ b/tools/testing/kunit/configs/all_tests.config
> >> @@ -49,3 +49,5 @@ CONFIG_SOUND=y
> >>   CONFIG_SND=y
> >>   CONFIG_SND_SOC=y
> >>   CONFIG_SND_SOC_TOPOLOGY_BUILD=y
> >> +
> >> +CONFIG_FW_CS_DSP=y
> >> \ No newline at end of file
> >> --
> >> 2.48.1
> >>
> >
>