linux-kernel - Re: [PATCH] kunit: cs_dsp: Depend on FW_CS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <618b8578-1897-45e4-83eb-b725102ab27d@sirena.org.uk>
Date: Thu, 20 Mar 2025 19:13:58 +0000
From: Mark Brown <broonie@...nel.org>
To: Nico Pache <npache@...hat.com>
Cc: rf@...nsource.cirrus.com, patches@...nsource.cirrus.com,
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
	kunit-dev@...glegroups.com, simont@...nsource.cirrus.com,
	ckeepax@...nsource.cirrus.com, brendan.higgins@...ux.dev,
	davidgow@...gle.com, rmoar@...gle.com, johannes.berg@...el.com,
	sj@...nel.org
Subject: Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling
 it

On Wed, Mar 19, 2025 at 05:05:39PM -0600, Nico Pache wrote:
> FW_CS_DSP gets enabled if KUNIT is enabled. The test should rather
> depend on if the feature is enabled. Fix this by moving FW_CS_DSP to the
> depends on clause, and set CONFIG_FW_CS_DSP=y in the kunit tooling.

>  config FW_CS_DSP_KUNIT_TEST
>  	tristate "KUnit tests for Cirrus Logic cs_dsp" if !KUNIT_ALL_TESTS
> -	depends on KUNIT && REGMAP
> +	depends on KUNIT && REGMAP && FW_CS_DSP
>  	default KUNIT_ALL_TESTS
> -	select FW_CS_DSP

This makes no sense to me, the select statement is forcing on the code
it's testing which is a library and so is selected by it's users, this
change will just stop the tests being run unless someone does the dance
to enable a driver which relies on the library.  That is something that
seems unlikely to change the outcome of the tests when run from KUnit
which is independent of any hardware.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)