linux-kernel - Re: [PATCH 06/11] HID: asus: introduce small delay on Asus Z13 RGB init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42531720-ad01-497f-96f5-5cd3ee16afa0@ljones.dev>
Date: Fri, 21 Mar 2025 10:03:48 +1300
From: "Luke D. Jones" <luke@...nes.dev>
To: Antheas Kapenekakis <lkml@...heas.dev>
Cc: platform-driver-x86@...r.kernel.org, linux-input@...r.kernel.org,
 linux-kernel@...r.kernel.org, Jiri Kosina <jikos@...nel.org>,
 Benjamin Tissoires <bentiss@...nel.org>,
 Corentin Chary <corentin.chary@...il.com>,
 Hans de Goede <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Subject: Re: [PATCH 06/11] HID: asus: introduce small delay on Asus Z13 RGB
 init

On 20/03/25 21:30, Antheas Kapenekakis wrote:
> On Thu, 20 Mar 2025 at 08:12, Luke D. Jones <luke@...nes.dev> wrote:
>>
>> On 20/03/25 08:13, Antheas Kapenekakis wrote:
>>> The folio keyboard of the Z13 can get stuck in its BIOS mode, where the
>>> touchpad behaves like a mouse and the keyboard start button is not
>>> reliable if we perform the initialization too quickly. This mostly
>>> happens during boot, and can be verified to be caused by hid-asus
>>> through simple blacklisting. A small delay fixes it.
>>>
>>> Signed-off-by: Antheas Kapenekakis <lkml@...heas.dev>
>>> ---
>>>    drivers/hid/hid-asus.c | 4 ++++
>>>    1 file changed, 4 insertions(+)
>>>
>>> diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
>>> index 85ae75478b796..5b75ee83ae290 100644
>>> --- a/drivers/hid/hid-asus.c
>>> +++ b/drivers/hid/hid-asus.c
>>> @@ -571,6 +571,10 @@ static int asus_kbd_register_leds(struct hid_device *hdev)
>>>        unsigned char kbd_func;
>>>        int ret;
>>>
>>> +     /* Wait a bit before init to prevent locking the keyboard */
>>> +     if (dmi_match(DMI_PRODUCT_FAMILY, "ROG Flow Z13"))
>>> +             msleep(500);
>>> +
>>>        ret = asus_kbd_init(hdev);
>>>        if (ret < 0)
>>>                return ret;
>>
>> See my comment on patch 1 about trying a loop with the init
>> request/response as a hopeful way to test readiness.
>>
>> Cheers,
>> Luke.
> 
> Turns out there isn't an init problem. I have removed this patch from V2.
> 
> It was hid-asus taking control of the touchpad from hid-multitouch. So
> adding HID_GROUP_GENERIC fixes this. I replaced it with that and
> squashed the rename patch alongside it.
> 
> Antheas

Awesome. Is this the one on `#define INPUT_REPORT_ID 0x5d`?