linux-kernel - Re: [PATCH 1/1] x86/hyperv: Add comments about hv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9yLNUEEutvjD6HZ@liuwe-devbox-ubuntu-v2.lamzopl0uupeniq2etz1fddiyg.xx.internal.cloudapp.net>
Date: Thu, 20 Mar 2025 21:40:05 +0000
From: Wei Liu <wei.liu@...nel.org>
To: mhklinux@...look.com
Cc: kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org,
	decui@...rosoft.com, tglx@...utronix.de, mingo@...hat.com,
	bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org,
	hpa@...or.com, linux-hyperv@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] x86/hyperv: Add comments about hv_vpset and var size
 hypercall input args

On Tue, Mar 18, 2025 at 02:49:19PM -0700, mhkelley58@...il.com wrote:
> From: Michael Kelley <mhklinux@...look.com>
> 
> Current code varies in how the size of the variable size input header
> for hypercalls is calculated when the input contains struct hv_vpset.
> Surprisingly, this variation is correct, as different hypercalls make
> different choices for what portion of struct hv_vpset is treated as part
> of the variable size input header. The Hyper-V TLFS is silent on these
> details, but the behavior has been confirmed with Hyper-V developers.
> 
> To avoid future confusion about these differences, add comments to
> struct hv_vpset, and to hypercall call sites with input that contains
> a struct hv_vpset. The comments describe the overall situation and
> the calculation that should be used at each particular call site.
> 
> No functional change as only comments are updated.
> 
> Signed-off-by: Michael Kelley <mhklinux@...look.com>

Applied to hyperv-next.	Thanks.