linux-kernel - Re: [PATCH] arm64: dts: qcom: x1e80100-hp-omnibook-x14: Enable SMB2360 0 and 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1b6657c-9da4-4435-81ae-857c27d18beb@nxsw.ie>
Date: Thu, 20 Mar 2025 22:20:14 +0000
From: Bryan O'Donoghue <bod.linux@...w.ie>
To: Juerg Haefliger <juerg.haefliger@...onical.com>, andersson@...nel.org, konradybcio@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, jens.glathe@...schoolsolutions.biz
Subject: Re: [PATCH] arm64: dts: qcom: x1e80100-hp-omnibook-x14: Enable SMB2360 0 and 1

On 19/03/2025 16:05, Juerg Haefliger wrote:
> Commit d37e2646c8a5 ("arm64: dts: qcom: x1e80100-pmics: Enable all SMB2360
> separately") disables all SMB2360s and let the board DTS explicitly enable
> them. The HP OmniBook DTS is from before this change and is missing the
> explicit enabling. Add that to get all USB root ports.
> 
> Fixes: 6f18b8d4142c ("arm64: dts: qcom: x1e80100-hp-x14: dt for HP Omnibook X Laptop 14")
> Cc: stable@...r.kernel.org      # 6.14
> Signed-off-by: Juerg Haefliger <juerg.haefliger@...onical.com>
> ---
>   arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts b/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts
> index cd860a246c45..c4ac0aaa6f65 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts
> @@ -1352,18 +1352,22 @@ &remoteproc_cdsp {
>   	status = "okay";
>   };
> 
> +&smb2360_0 {
> +	status = "okay";
> +};
> +
>   &smb2360_0_eusb2_repeater {
>   	vdd18-supply = <&vreg_l3d_1p8>;
>   	vdd3-supply = <&vreg_l2b_3p0>;
> +};
> 
> +&smb2360_1 {
>   	status = "okay";
>   };
> 
>   &smb2360_1_eusb2_repeater {
>   	vdd18-supply = <&vreg_l3d_1p8>;
>   	vdd3-supply = <&vreg_l14b_3p0>;
> -
> -	status = "okay";
>   };
> 
>   &swr0 {
> --
> 2.43.0
> 
> 

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>