linux-kernel - Re: [PATCH] objtool: fix resource leak in copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ddhqswvpl43jfuaj26hwxmac5gvgxhr4lv2cpsk3k5x62cjjf7@6ewsreyaclap>
Date: Thu, 20 Mar 2025 16:46:22 -0700
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: Qasim Ijaz <qasdev00@...il.com>
Cc: peterz@...radead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] objtool: fix resource leak in copy_file()

On Thu, Mar 20, 2025 at 11:31:31PM +0000, Qasim Ijaz wrote:
> Close open file descriptors on error paths in copy_file() to prevent
> resource leaks when open(), fstat(), fchmod(), or sendfile() fail.
> 
> Fixes: 5a406031d071 ("objtool: Add --output option")
> Signed-off-by: Qasim Ijaz <qasdev00@...il.com>

Hi,

Thanks for the patch, but objtool is a short running process, so we
generally don't care about memory leaks.

-- 
Josh