linux-kernel - Re: [PATCH v2 12/57] irqdomain: Make irq_domain_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <325b1936-38c1-4190-9f7f-3c6b00b91efa@kernel.org>
Date: Thu, 20 Mar 2025 07:08:15 +0100
From: Jiri Slaby <jirislaby@...nel.org>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: tglx@...utronix.de, maz@...nel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 12/57] irqdomain: Make irq_domain_create_hierarchy() an
 inline

On 19. 03. 25, 10:44, Ilpo Järvinen wrote:
> On Wed, 19 Mar 2025, Jiri Slaby (SUSE) wrote:
> 
>> There is no reason to export the function as an extra symbol. It is
>> simple enough and is just a wrapper to already exported functions.
>>
>> Therefore, switch the exported function to an inline.
>>
>> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
>> ---
>>   include/linux/irqdomain.h | 45 +++++++++++++++++++++++++++++++++------
>>   kernel/irq/irqdomain.c    | 41 -----------------------------------
>>   2 files changed, 39 insertions(+), 47 deletions(-)
>>
>> diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h
>> index 5eaaf74647ed..1480951a690b 100644
>> --- a/include/linux/irqdomain.h
>> +++ b/include/linux/irqdomain.h
>> @@ -591,12 +591,45 @@ void irq_domain_set_info(struct irq_domain *domain, unsigned int virq,
>>   			 void *handler_data, const char *handler_name);
>>   void irq_domain_reset_irq_data(struct irq_data *irq_data);
>>   #ifdef	CONFIG_IRQ_DOMAIN_HIERARCHY
>> -struct irq_domain *irq_domain_create_hierarchy(struct irq_domain *parent,
>> -					       unsigned int flags,
>> -					       unsigned int size,
>> -					       struct fwnode_handle *fwnode,
>> -					       const struct irq_domain_ops *ops,
>> -					       void *host_data);
>> +/**
>> + * irq_domain_create_hierarchy - Add a irqdomain into the hierarchy
>> + * @parent:	Parent irq domain to associate with the new domain
>> + * @flags:	Irq domain flags associated to the domain
>> + * @size:	Size of the domain. See below
>> + * @fwnode:	Optional fwnode of the interrupt controller
>> + * @ops:	Pointer to the interrupt domain callbacks
>> + * @host_data:	Controller private data pointer
>> + *
>> + * If @size is 0 a tree domain is created, otherwise a linear domain.
>> + *
>> + * If successful the parent is associated to the new domain and the
>> + * domain flags are set.
>> + * Returns pointer to IRQ domain, or NULL on failure.
> 
>      *
>      * Return: ...
> 
> ...is what kerneldoc documentation suggest is the right formatting.

Right, fixed.

thanks,
-- 
js
suse labs