linux-kernel - Re: [PATCH] iio: light: bh1750: Add hardware reset support via GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f4556511-3123-4131-af2f-c4044302979e@kernel.org>
Date: Thu, 20 Mar 2025 08:18:48 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sergio Pérez <sergio@...eznus.es>,
 linux-iio@...r.kernel.org
Cc: tduszyns@...il.com, jic23@...nel.org, lars@...afoo.de, robh@...nel.org,
 conor+dt@...nel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH] iio: light: bh1750: Add hardware reset support via GPIO

On 19/03/2025 17:26, Sergio Pérez wrote:
> 
> El 19/03/2025 a las 9:46, Krzysztof Kozlowski escribió:
>> On 18/03/2025 18:37, Krzysztof Kozlowski wrote:
>>>> I've now run the tool correctly on my patch file and have fixed the
>>>> identified issues:
>>>> - Removed trailing whitespace
>>>> - Fixed lines exceeding 79 characters
>>>> - Fixed the inconsistency between the description and example for
>>>> reset-gpios
>>>> - Modified the existing example instead of adding a new one
>>>> - Ensured proper line endings and formatting
>>>> - Used proper get_maintainers.pl to include all recipients
>>>>
>>> Please read the guides carefully. The process is extremely simple as:
>>>
>>> git add ...
>>> git commit --signed-off
>>> git format-patch -v3 -2
>>> scripts/chekpatch.pl v3*
>>> scripts/get_maintainers.pl --no-git-fallback v3*
>>> git send-email *
>> Please read this again. I gave you detailed instruction which you still
>> decided not to follow. The instructions are quite precise on purpose,
>> because other method leads to wrong patchset - broken that or other way.
>>
> I transcribe exactly the commands I have executed:
> 
> $ git add Documentation/devicetree/bindings/iio/light/bh1750.yaml
> 
> $ git commit --signed-off
> 
> $ git add drivers/iio/light/bh1750.c
> 
> $ git commit --signed-off
> 
> $ git format-patch -v3 -2

So v3 or v4 or v5? After this email (dated 18th March), you sent v4, two
hours later not following mentioned process.

And then yesterday you sent v3 again, why this is supposed to be v5.

Read the help of these commands, instead of copying them blindly without
thinking. Every version is v3?

Best regards,
Krzysztof