linux-kernel - [PATCH] drm/bridge: ite-it6505: Use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250320155552836BxTzConO0YrJHJ34CDDtl@zte.com.cn>
Date: Thu, 20 Mar 2025 15:55:52 +0800 (CST)
From: <shao.mingyin@....com.cn>
To: <andrzej.hajda@...el.com>
Cc: <neil.armstrong@...aro.org>, <rfoss@...nel.org>,
        <laurent.pinchart@...asonboard.com>, <jonas@...boo.se>,
        <jernej.skrabec@...il.com>, <linux-kernel@...r.kernel.org>,
        <xu.xin16@....com.cn>, <yang.yang29@....com.cn>
Subject: [PATCH] drm/bridge: ite-it6505: Use dev_err_probe()

From: Zhang Enpei <zhang.enpei@....com.cn>

The function extcon_get_edev_by_phandle can return -EPROBE_DEFER, so
replace dev_err call with dev_err_probe. This also simplifies the code
sequence.

Signed-off-by: Zhang Enpei <zhang.enpei@....com.cn>
Signed-off-by: Shao Mingyin <shao.mingyin@....com.cn>
---
 drivers/gpu/drm/bridge/ite-it6505.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
index 8a607558ac89..1be1ffff505f 100644
--- a/drivers/gpu/drm/bridge/ite-it6505.c
+++ b/drivers/gpu/drm/bridge/ite-it6505.c
@@ -3635,12 +3635,9 @@ static int it6505_i2c_probe(struct i2c_client *client)

 	/* get extcon device from DTS */
 	extcon = extcon_get_edev_by_phandle(dev, 0);
-	if (PTR_ERR(extcon) == -EPROBE_DEFER)
-		return -EPROBE_DEFER;
-	if (IS_ERR(extcon)) {
-		dev_err(dev, "can not get extcon device!");
-		return PTR_ERR(extcon);
-	}
+	if (IS_ERR(extcon))
+		return dev_err_probe(dev, PTR_ERR(extcon),
+				     "can not get extcon device!");

 	it6505->extcon = extcon;

-- 
2.25.1