linux-kernel - Re: [PATCH v2 21/57] irqdomain: irqchip: Switch to irq_domain_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZ95MdKgmjqzL_68BLsqpF+gOgbq3qSuEc_JG=x-=RvQg@mail.gmail.com>
Date: Thu, 20 Mar 2025 09:25:37 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
Cc: tglx@...utronix.de, maz@...nel.org, linux-kernel@...r.kernel.org, 
	Krzysztof Kozlowski <krzk@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>, 
	Talel Shenhar <talel@...zon.com>, Antoine Tenart <atenart@...nel.org>, Andrew Lunn <andrew@...n.ch>, 
	Gregory Clement <gregory.clement@...tlin.com>, 
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>, Ryan Chen <ryan_chen@...eedtech.com>, 
	Benjamin Herrenschmidt <benh@...nel.crashing.org>, Joel Stanley <joel@....id.au>, 
	Andrew Jeffery <andrew@...econstruct.com.au>, Eddie James <eajames@...ux.ibm.com>, 
	Nicolas Ferre <nicolas.ferre@...rochip.com>, 
	Alexandre Belloni <alexandre.belloni@...tlin.com>, Claudiu Beznea <claudiu.beznea@...on.dev>, 
	Florian Fainelli <florian.fainelli@...adcom.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Ray Jui <rjui@...adcom.com>, 
	Scott Branden <sbranden@...adcom.com>, Guo Ren <guoren@...nel.org>, 
	Baruch Siach <baruch@...s.co.il>, Miodrag Dinic <miodrag.dinic@...s.com>, 
	Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, 
	Paul Cercueil <paul@...pouillou.net>, Vladimir Zapolskiy <vz@...ia.com>, 
	Piotr Wojtaszczyk <piotr.wojtaszczyk@...esys.com>, 
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>, Mark-PK Tsai <mark-pk.tsai@...iatek.com>, 
	Daniel Palmer <daniel@...ngy.jp>, Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
	Aaro Koskinen <aaro.koskinen@....fi>, Andreas Kemnade <andreas@...nade.info>, 
	Kevin Hilman <khilman@...libre.com>, Roger Quadros <rogerq@...nel.org>, 
	Tony Lindgren <tony@...mide.com>, Jonas Bonn <jonas@...thpole.se>, 
	Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>, Stafford Horne <shorne@...il.com>, 
	Andreas Färber <afaerber@...e.de>, 
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, Qin Jian <qinjian@...lus1.com>, 
	Changhuang Liang <changhuang.liang@...rfivetech.com>, 
	Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, 
	Chen-Yu Tsai <wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>, 
	Samuel Holland <samuel@...lland.org>, Thierry Reding <thierry.reding@...il.com>, 
	Jonathan Hunter <jonathanh@...dia.com>, Nishanth Menon <nm@...com>, Tero Kristo <kristo@...nel.org>, 
	Santosh Shilimkar <ssantosh@...nel.org>, Jonathan Neuschäfer <j.neuschaefer@....net>, 
	Michal Simek <michal.simek@....com>, Chris Zankel <chris@...kel.net>, 
	Max Filippov <jcmvbkbc@...il.com>
Subject: Re: [PATCH v2 21/57] irqdomain: irqchip: Switch to irq_domain_create_*()

On Wed, Mar 19, 2025 at 10:31 AM Jiri Slaby (SUSE) <jirislaby@...nel.org> wrote:

> irq_domain_add_*() interfaces are going away as being obsolete now.
> Switch to the preferred irq_domain_create_*() ones. Those differ in the
> node parameter: They take more generic struct fwnode_handle instead of
> struct device_node. Therefore, of_fwnode_handle() is added around the
> original parameter.
>
> Note some of the users can likely use dev->fwnode directly instead of
> indirect of_fwnode_handle(dev->of_node). But dev->fwnode is not
> guaranteed to be set for all, so this has to be investigated on case to
> case basis (by people who can actually test with the HW).
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>

There are some stray whitespace changes which are distracting,
but as things are, there is
Documentation/process/4.Coding.rst
saying:

  It is natural to fix the style of a piece of code while working
  on it for other reasons, but coding style changes should not be made for
  their own sake.

...and you are working on the code for other reasons so I
read it like this is actually OK.

(Written mostly to forestall any similar comments.)

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij