linux-kernel - Re: [PATCH 09/11] platform/x86: asus-wmi: remove unused keyboard backlight quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <CAGwozwGHfGHrKAW4_Q5NOGX4+6E8iwexJ6F6w2oaVY4jqNxrFQ@mail.gmail.com>
Date: Thu, 20 Mar 2025 09:28:42 +0100
From: Antheas Kapenekakis <lkml@...heas.dev>
To: "Luke D. Jones" <luke@...nes.dev>
Cc: platform-driver-x86@...r.kernel.org, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, Jiri Kosina <jikos@...nel.org>,
	Benjamin Tissoires <bentiss@...nel.org>,
 Corentin Chary <corentin.chary@...il.com>,
	Hans de Goede <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Subject: Re: [PATCH 09/11] platform/x86: asus-wmi: remove unused keyboard
 backlight quirk

On Thu, 20 Mar 2025 at 08:11, Luke D. Jones <luke@...nes.dev> wrote:
>
> On 20/03/25 08:13, Antheas Kapenekakis wrote:
> > The quirk for selecting whether keyboard backlight should be controlled
> > by HID or WMI is not needed anymore, so remove it.
> >
> > Signed-off-by: Antheas Kapenekakis <lkml@...heas.dev>
> > ---
> >   include/linux/platform_data/x86/asus-wmi.h | 40 ----------------------
> >   1 file changed, 40 deletions(-)
> >
> > diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/platform_data/x86/asus-wmi.h
> > index 42e963b70acdb..add04524031d8 100644
> > --- a/include/linux/platform_data/x86/asus-wmi.h
> > +++ b/include/linux/platform_data/x86/asus-wmi.h
> > @@ -183,44 +183,4 @@ static inline void asus_brt_unregister_listener(struct asus_brt_listener *bdev)
> >   }
> >   #endif
> >
> > -/* To be used by both hid-asus and asus-wmi to determine which controls kbd_brightness */
> > -static const struct dmi_system_id asus_use_hid_led_dmi_ids[] = {
> > -     {
> > -             .matches = {
> > -                     DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Zephyrus"),
> > -             },
> > -     },
> > -     {
> > -             .matches = {
> > -                     DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Strix"),
> > -             },
> > -     },
> > -     {
> > -             .matches = {
> > -                     DMI_MATCH(DMI_PRODUCT_FAMILY, "ROG Flow"),
> > -             },
> > -     },
> > -     {
> > -             .matches = {
> > -                     DMI_MATCH(DMI_PRODUCT_FAMILY, "ProArt P16"),
> > -             },
> > -     },
> > -     {
> > -             .matches = {
> > -                     DMI_MATCH(DMI_BOARD_NAME, "GA403U"),
> > -             },
> > -     },
> > -     {
> > -             .matches = {
> > -                     DMI_MATCH(DMI_BOARD_NAME, "GU605M"),
> > -             },
> > -     },
> > -     {
> > -             .matches = {
> > -                     DMI_MATCH(DMI_BOARD_NAME, "RC71L"),
> > -             },
> > -     },
> > -     { },
> > -};
> > -
> >   #endif      /* __PLATFORM_DATA_X86_ASUS_WMI_H */
>
> I think this can be squashed in to patch 8 as it looks likely to cause
> an "unused" warning or error? I'll defer to others though.

I tried to avoid going cross-platform for these three patches. If
someone has a better suggestion to do it I would be happy to do that
instead, incl maybe adding a __maybe_unused as part of the previous
patch.

> Cheers,
> Luke.
>

Antheas