linux-kernel - Re: [PATCH v5 12/16] arm64: add KHO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250320-muscular-cougar-of-apotheosis-e4c80b@krzk-bin>
Date: Thu, 20 Mar 2025 09:30:46 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Changyuan Lyu <changyuanl@...gle.com>, linux-kernel@...r.kernel.org
Cc: graf@...zon.com, akpm@...ux-foundation.org, luto@...nel.org, 
	anthony.yznaga@...cle.com, arnd@...db.de, ashish.kalra@....com, benh@...nel.crashing.org, 
	bp@...en8.de, catalin.marinas@....com, dave.hansen@...ux.intel.com, 
	dwmw2@...radead.org, ebiederm@...ssion.com, mingo@...hat.com, jgowans@...zon.com, 
	corbet@....net, rppt@...nel.org, mark.rutland@....com, pbonzini@...hat.com, 
	pasha.tatashin@...een.com, hpa@...or.com, peterz@...radead.org, ptyadav@...zon.de, 
	robh+dt@...nel.org, robh@...nel.org, saravanak@...gle.com, 
	skinsburskii@...ux.microsoft.com, rostedt@...dmis.org, tglx@...utronix.de, thomas.lendacky@....com, 
	usama.arif@...edance.com, will@...nel.org, devicetree@...r.kernel.org, 
	kexec@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, linux-doc@...r.kernel.org, 
	linux-mm@...ck.org, x86@...nel.org
Subject: Re: [PATCH v5 12/16] arm64: add KHO support

On Thu, Mar 20, 2025 at 08:13:24AM +0100, Krzysztof Kozlowski wrote:
> On 20/03/2025 02:55, Changyuan Lyu wrote:
> >  
> > +/**
> > + * early_init_dt_check_kho - Decode info required for kexec handover from DT
> > + */
> > +static void __init early_init_dt_check_kho(void)
> > +{
> > +	unsigned long node = chosen_node_offset;
> > +	u64 kho_start, scratch_start, scratch_size;
> > +	const __be32 *p;
> > +	int l;
> > +
> > +	if (!IS_ENABLED(CONFIG_KEXEC_HANDOVER) || (long)node < 0)
> > +		return;
> > +
> > +	p = of_get_flat_dt_prop(node, "linux,kho-fdt", &l);
> 
> 
> You are adding undocumented ABI for OF properties. That's not what was
> explained last time.
> 
> NAK.

Also there are checkpatch warnings :/

Best regards,
Krzysztof