linux-kernel - Re: [PATCH v4 1/5] dt-bindings: net: Add network-class schema for mac-address properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250320-cocky-proficient-alligator-5da8a2@krzk-bin>
Date: Thu, 20 Mar 2025 09:35:43 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: David Heidelberg <david@...t.cz>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Mailing List <devicetree-spec-u79uwXL29TY76Z2rM5mHXA@...lic.gmane.org>, Johannes Berg <johannes@...solutions.net>, 
	Lorenzo Bianconi <lorenzo@...nel.org>, van Spriel <arend@...adcom.com>, 
	Jérôme Pouiller <jerome.pouiller@...abs.com>, Bjorn Andersson <andersson@...nel.org>, 
	Konrad Dybcio <konradybcio@...nel.org>, Andy Gross <agross@...nel.org>, 
	Mailing List <devicetree-spec@...r.kernel.org>, netdev@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
	Janne Grunau <j@...nau.net>
Subject: Re: [PATCH v4 1/5] dt-bindings: net: Add network-class schema for
 mac-address properties

On Wed, Mar 19, 2025 at 08:42:46AM +0100, David Heidelberg wrote:
> From: Janne Grunau <j@...nau.net>
> 
> The ethernet-controller schema specifies "mac-address" and
> "local-mac-address" but other network devices such as wireless network
> adapters use mac addresses as well.
> The Devicetree Specification, Release v0.3 specifies in section 4.3.1
> a generic "Network Class Binding" with "address-bits", "mac-address",
> "local-mac-address" and "max-frame-size". This schema specifies the
> "address-bits" property and moves the remaining properties over from
> the ethernet-controller.yaml schema.
> 
> The "max-frame-size" property is used to describe the maximal payload
> size despite its name. Keep the description from ethernet-controller
> specifying this property as MTU. The contradictory description in the
> Devicetree Specification is ignored.
> 
> Signed-off-by: Janne Grunau <j@...nau.net>

Incorrect DCO chain, missing SoB.

...

> +  - Devicetree Specification Mailing List <devicetree-spec@...r.kernel.org>
> +
> +properties:
> +  address-bits:
> +    description:
> +      Specifies number of address bits required to address the device described

"Specifies number of address bits required to address the device
described by this node, e.g. size of the MAC address."

And drop the second sentence.

> +      by this node. This property specifies number of bits in MAC address.
> +    default: 48
> +    const: 48
> +

...

> +  mac-address:
> +    description:
> +      Specifies the MAC address that was last used by the boot program. This
> +      property should be used in cases where the MAC address assigned to the
> +      device by the boot program is different from the
> +      local-mac-address property. This property shall be used only if the value
> +      differs from local-mac-address property value.
> +    $ref: /schemas/types.yaml#/definitions/uint8-array
> +    minItems: 6
> +    maxItems: 6
> +
> +  max-frame-size:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Maximum transfer unit (IEEE defined MTU), rather than the
> +      maximum frame size (there\'s contradiction in the Devicetree
> +      Specification).
> +
> +

Just one blank line

> +additionalProperties: true
> 

Best regards,
Krzysztof