linux-kernel - Re: [PATCH v2] fs: reduce work in fdget

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250320-mehrfach-erneuerbar-5ed797872973@brauner>
Date: Thu, 20 Mar 2025 09:47:11 +0100
From: Christian Brauner <brauner@...nel.org>
To: Mateusz Guzik <mjguzik@...il.com>
Cc: Christian Brauner <brauner@...nel.org>,
	viro@...iv.linux.org.uk,
	jack@...e.cz,
	linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v2] fs: reduce work in fdget_pos()

On Wed, 19 Mar 2025 22:58:01 +0100, Mateusz Guzik wrote:
> 1. predict the file was found
> 2. explicitly compare the ref to "one", ignoring the dead zone
> 
> The latter arguably improves the behavior to begin with. Suppose the
> count turned bad -- the previously used ref routine is going to check
> for it and return 0, indicating the count does not necessitate taking
> ->f_pos_lock. But there very well may be several users.
> 
> [...]

Applied to the vfs-6.15.file branch of the vfs/vfs.git tree.
Patches in the vfs-6.15.file branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.15.file

[1/1] fs: reduce work in fdget_pos()
      https://git.kernel.org/vfs/vfs/c/5370b43e4bcf