linux-kernel - Re: [PATCH v3 1/2] dt-bindings: iio: light: bh1750: Add reset-gpios property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250320-shaggy-heavy-camel-9d0eed@krzk-bin>
Date: Thu, 20 Mar 2025 09:52:31 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sergio Pérez <sergio@...eznus.es>
Cc: Tomasz Duszynski <tduszyns@...il.com>, 
	Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, linux-iio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: iio: light: bh1750: Add reset-gpios
 property

On Wed, Mar 19, 2025 at 11:38:09PM +0100, Sergio Pérez wrote:
> 
> El 19/03/2025 a las 20:12, Krzysztof Kozlowski escribió:
> > On 19/03/2025 17:11, Sergio Perez wrote:
> > > Some BH1750 sensors require a hardware reset via GPIO before they can
> > > be properly detected on the I2C bus. Add a new reset-gpios property
> > > to the binding to support this functionality.
> > > 
> > > The reset-gpios property allows specifying a GPIO that will be toggled
> > > during driver initialization to reset the sensor.
> > > 
> > > Signed-off-by: Sergio Perez <sergio@...eznus.es>
> > > ---
> > >   Documentation/devicetree/bindings/iio/light/bh1750.yaml | 5 +++++
> > >   1 file changed, 5 insertions(+)
> > You just sent v3, while v4 was already on the lists, without improving
> > and without responding to review.
> > 
> > NAK.
> > 
> > You keep repeating the same mistakes: not reading and responding
> > feedback and it is getting tiresome.
> I apologize for the confusion with patch versions. You're right that I sent
> v3
> after v4 was already on the list. I was trying to follow your exact
> instructions from:
> "git add ...
> git commit --signed-off
> git format-patch -v3 -2
> scripts/chekpatch.pl v3*
> scripts/get_maintainers.pl --no-git-fallback v3*
> git send-email *"

v3 stands for version of the patch, so my instruction shuld be here
adjusted.

> 
> Regarding the binding I've modified for next v5 the YAML description to
> remove "active low" to avoid confusion and modified the example to:

So the signal is not active low? Are you really sure?

Looking at BH1750FVI there is no reset signal in the first place...
unless you mean this is DVI, but the description should then mention it.

If this is DVI, then it is active low.

Best regards,
Krzysztof