linux-kernel - Re: [PATCH v2 03/10] vhost-scsi: Fix vhost_scsi_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACGkMEs3O2B0fAifAki9GdDiP-SX4pMviEOjqCsAkkzCyx90gg@mail.gmail.com>
Date: Thu, 20 Mar 2025 09:42:29 +0800
From: Jason Wang <jasowang@...hat.com>
To: Dongli Zhang <dongli.zhang@...cle.com>
Cc: virtualization@...ts.linux.dev, kvm@...r.kernel.org, 
	netdev@...r.kernel.org, mst@...hat.com, michael.christie@...cle.com, 
	pbonzini@...hat.com, stefanha@...hat.com, eperezma@...hat.com, 
	joao.m.martins@...cle.com, joe.jin@...cle.com, si-wei.liu@...cle.com, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 03/10] vhost-scsi: Fix vhost_scsi_send_status()

On Thu, Mar 20, 2025 at 1:54 AM Dongli Zhang <dongli.zhang@...cle.com> wrote:
>
> Hi Jason,
>
> On 3/17/25 5:48 PM, Jason Wang wrote:
> > On Tue, Mar 18, 2025 at 7:52 AM Dongli Zhang <dongli.zhang@...cle.com> wrote:
> >>
> >> Although the support of VIRTIO_F_ANY_LAYOUT + VIRTIO_F_VERSION_1 was
> >> signaled by the commit 664ed90e621c ("vhost/scsi: Set
> >> VIRTIO_F_ANY_LAYOUT + VIRTIO_F_VERSION_1 feature bits"),
> >> vhost_scsi_send_bad_target() still assumes the response in a single
> >> descriptor.
> >>
> >> Similar issue in vhost_scsi_send_bad_target() has been fixed in previous
> >> commit.
> >>
> >> Fixes: 3ca51662f818 ("vhost-scsi: Add better resource allocation failure handling")
> >
> > And
> >
> > 6dd88fd59da84631b5fe5c8176931c38cfa3b265 ("vhost-scsi: unbreak any
> > layout for response")
> >
>
> Would suggest add the commit to Fixes?
>
> vhost_scsi_send_status() has been introduced by the most recent patch.
>
> It isn't related to that commit. That commit is to fix
> vhost_scsi_complete_cmd_work()
>
> Or would you suggest mention it as part of "Similar issue has been fixed in
> previous commit."?

I'm fine with either, they are all fixes for any header layout anyhow.

Thanks

>
> Thank you very much!
>
> Dongli Zhang
>