linux-kernel - Re: [PATCH 2/4] dt-bindings: remoteproc: mediatek: Remove l1tcm for dual-core MT8188 SCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be4af783-3b98-439b-be3d-30d6ff520d2e@collabora.com>
Date: Thu, 20 Mar 2025 11:33:45 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Moudy Ho (何宗原) <Moudy.Ho@...iatek.com>,
 "robh@...nel.org" <robh@...nel.org>,
 "andersson@...nel.org" <andersson@...nel.org>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
 TingHan Shen (沈廷翰) <TingHan.Shen@...iatek.com>,
 "mathieu.poirier@...aro.org" <mathieu.poirier@...aro.org>,
 "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
 Nicolas Prado <nfraprado@...labora.com>,
 Olivia Wen (温倩苓) <Olivia.Wen@...iatek.com>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>
Cc: "linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "kernel@...labora.com" <kernel@...labora.com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH 2/4] dt-bindings: remoteproc: mediatek: Remove l1tcm for
 dual-core MT8188 SCP

Il 20/03/25 02:28, Moudy Ho (何宗原) ha scritto:
> On Wed, 2025-03-19 at 10:34 +0100, AngeloGioacchino Del Regno wrote:
>>
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>
>>
>> Il 18/03/25 23:22, Nícolas F. R. A. Prado ha scritto:
>>> The SCP present on MT8188 does not have an L1TCM memory region, but
>>> the
>>> binding incorrectly requires one for the dual-core description of
>>> the
>>> MT8188 SCP. Remove that requirement. Also update the minimum number
>>> of
>>> reg and reg-names to 1, since as this is a multi-core SCP with no
>>> L1TCM memory, only the CFG memory region is present in the parent
>>> node.
>>>
>>> Fixes: 91e0d560b9fd ("dt-bindings: remoteproc: mediatek: Support
>>> MT8188 dual-core SCP")
>>> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
>>
>> As far as I know, the L1TCM is present on MT8188, and it's at
>> 0x1070000 len 0x8000
>> exactly like MT8195.
>>
>> Moudy, are you able to please confirm or deny that?
>>
>> Cheers,
>> Angelo
>>
>>
> 
> Hi Angelo,
> 
> Unfortunately, during the transition from MT8195 to MT8188, the SCP
> removed the L1TCM, retaining only the SRAM and config register.
> For detailed hardware changes, you can refer to Tinghan's previous
> description at the following link.
> 
> ref:
> https://lore.kernel.org/all/20220715051821.30707-3-tinghan.shen@mediatek.com/
> 
Thanks Moudy!

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>