linux-kernel - [PATCH] KEYS: trusted: dcp: Use kfree_sensitive() to fix Coccinelle warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250320103557.7236-1-liubo03@inspur.com>
Date: Thu, 20 Mar 2025 06:35:57 -0400
From: Bo Liu <liubo03@...pur.com>
To: <dhowells@...hat.com>, <James.Bottomley@...senPartnership.com>,
	<jarkko@...nel.org>, <zohar@...ux.ibm.com>, <paul@...l-moore.com>,
	<jmorris@...ei.org>, <serge@...lyn.com>
CC: <linux-integrity@...r.kernel.org>, <keyrings@...r.kernel.org>,
	<linux-security-module@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Bo
 Liu <liubo03@...pur.com>
Subject: [PATCH] KEYS: trusted: dcp: Use kfree_sensitive() to fix Coccinelle warnings

Replace memzero_explicit() and kfree() with kfree_sensitive() to fix
warnings reported by Coccinelle:

WARNING opportunity for kfree_sensitive/kvfree_sensitive
WARNING opportunity for kfree_sensitive/kvfree_sensitive

Signed-off-by: Bo Liu <liubo03@...pur.com>
---
 security/keys/trusted-keys/trusted_dcp.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/security/keys/trusted-keys/trusted_dcp.c b/security/keys/trusted-keys/trusted_dcp.c
index 7b6eb655df0c..c967837e72ee 100644
--- a/security/keys/trusted-keys/trusted_dcp.c
+++ b/security/keys/trusted-keys/trusted_dcp.c
@@ -233,8 +233,7 @@ static int trusted_dcp_seal(struct trusted_key_payload *p, char *datablob)
 	ret = 0;
 
 out:
-	memzero_explicit(plain_blob_key, AES_KEYSIZE_128);
-	kfree(plain_blob_key);
+	kfree_sensitive(plain_blob_key);
 
 	return ret;
 }
@@ -283,8 +282,7 @@ static int trusted_dcp_unseal(struct trusted_key_payload *p, char *datablob)
 	ret = 0;
 out:
 	if (plain_blob_key) {
-		memzero_explicit(plain_blob_key, AES_KEYSIZE_128);
-		kfree(plain_blob_key);
+		kfree_sensitive(plain_blob_key);
 	}
 
 	return ret;
-- 
2.31.1