linux-kernel - Re: [PATCH] dma/idxd: Remove _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z9vzM7UedzpkdHKZ@smile.fi.intel.com>
Date: Thu, 20 Mar 2025 12:51:31 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Yi Sun <yi.sun@...el.com>
Cc: dave.jiang@...el.com, anil.s.keshavamurthy@...el.com, vkoul@...nel.org,
	dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
	gordon.jin@...el.com, yi.sun@...ux.intel.com
Subject: Re: [PATCH] dma/idxd: Remove __packed from structures

On Thu, Mar 20, 2025 at 04:18:07PM +0800, Yi Sun wrote:
> The __packed attribute introduces potential unaligned memory accesses
> and endianness portability issues. Instead of relying on compiler-specific
> packing, it's much better to explicitly fill structure gaps using padding
> fields, ensuring natural alignment.
> 
> Since all previously __packed structures already enforce proper alignment
> through manual padding, the __packed qualifiers are unnecessary and can be
> safely removed.

FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

-- 
With Best Regards,
Andy Shevchenko