linux-kernel - Re: [PATCH v3] i2c-mlxbf: Add repeated start condition support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <qmsa5g5bktfknhw2xmcdgtpwxql4fxkl2gbpkezbwnhgsrxncj@375ed77upc4a>
Date: Thu, 20 Mar 2025 12:05:24 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Chris Babroski <cbabroski@...dia.com>
Cc: kblaiech@...dia.com, asmaa@...dia.com, davthompson@...dia.com, 
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] i2c-mlxbf: Add repeated start condition support

Hi Chris,

sorry for looking into this patch so late.

On Fri, Jan 31, 2025 at 05:50:16PM +0000, Chris Babroski wrote:
> Add support for SMBus repeated start conditions to the Mellanox I2C
> driver. This support is specifically enabled for the
> I2C_FUNC_SMBUS_WRITE_I2C_BLOCK implementation which is required for
> communication with an I2C device on BlueField 3.
> 
> The I2C bus timing configuration values have also been updated to fix
> an issue found when testing block reads requiring a repeated start
> condition. The "timeout" value, which determines how long the clock
> can be held low before the I2C transaction is aborted, was too short
> and caused unwanted failures. It was also found that other timing values
> do not match the configuration that is recommended and has been verified by
> the BlueField HW team so those values have been updated as well.

Could we split this patches into two parts? It looks good to me,
so that once you send it, I will apply it right away.

Thanks,
Andi