linux-kernel - Re: [PATCH v2 2/5] mux: gpio: add optional regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <AM7P189MB1009C401F0C8B95496DB183EE3D82@AM7P189MB1009.EURP189.PROD.OUTLOOK.COM>
Date: Thu, 20 Mar 2025 13:16:12 +0100
From: Maud Spierings <maud_spierings@...mail.com>
To: srinivas.kandagatla@...aro.org
Cc: andersson@...nel.org, broonie@...nel.org, conor+dt@...nel.org,
 devicetree@...r.kernel.org, dmitry.baryshkov@....qualcomm.com,
 ivprusov@...utedevices.com, johan+linaro@...nel.org, konradybcio@...nel.org,
 krzk+dt@...nel.org, lgirdwood@...il.com, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org,
 luca.ceresoli@...tlin.com, paulha@...nsource.cirrus.com, peda@...ntia.se,
 perex@...ex.cz, robh@...nel.org, tiwai@...e.com, zhoubinbin@...ngson.cn
Subject: Re: [PATCH v2 2/5] mux: gpio: add optional regulator support

> From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> 
> Some of the external muxes needs powering up using a regulator.
> This is the case with Lenovo T14s laptop which has a external audio mux
> to handle US/EURO headsets.
> 
> Add support to the driver to handle this optional regulator.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> ---
>  drivers/mux/gpio.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/mux/gpio.c b/drivers/mux/gpio.c
> index cc5f2c1861d4..12cd9b5c32fb 100644
> --- a/drivers/mux/gpio.c
> +++ b/drivers/mux/gpio.c
> @@ -15,6 +15,7 @@
>  #include <linux/mux/driver.h>
>  #include <linux/platform_device.h>
>  #include <linux/property.h>
> +#include <linux/regulator/consumer.h>
>  
>  struct mux_gpio {
>  	struct gpio_descs *gpios;
> @@ -82,6 +83,13 @@ static int mux_gpio_probe(struct platform_device *pdev)
>  		mux_chip->mux->idle_state = idle_state;
>  	}
>  
> +	ret = devm_regulator_get_enable_optional(dev, "mux");
> +	if (ret && ret != -ENODEV) {
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(dev, "Couldn't retrieve/enable gpio mux supply\n");
> +		return ret;
> +	}

This seems like a good place to use return dev_err_probe()

> +
>  	ret = devm_mux_chip_register(dev, mux_chip);
>  	if (ret < 0)
>  		return ret;
> -- 
> 2.39.5

Kind regards,
Maud