linux-kernel - Re: [PATCH -next 2/2] staging: gpib: Remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025032037-antibody-emptier-9986@gregkh>
Date: Thu, 20 Mar 2025 07:01:19 -0700
From: Greg KH <gregkh@...uxfoundation.org>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: dpenkler@...il.com, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next 2/2] staging: gpib: Remove unnecessary print
 function dev_err()

On Wed, Feb 26, 2025 at 02:07:35PM +0800, Jiapeng Chong wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
> 
> ./drivers/staging/gpib/fmh_gpib/fmh_gpib.c:1426:2-9: line 1426 is redundant because platform_get_irq() already prints an error.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=19059
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  drivers/staging/gpib/fmh_gpib/fmh_gpib.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

You have 2 different patches here, yet the identical subject line.  I
just caught this after I added it to my staging-testing branch, so I'll
go drop it from there now and wait for a v2 series.

thanks,

greg k-h