linux-kernel - Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250320150957.0507abb5.pasic@linux.ibm.com>
Date: Thu, 20 Mar 2025 15:09:57 +0100
From: Halil Pasic <pasic@...ux.ibm.com>
To: Maximilian Immanuel Brandtner <maxbr@...ux.ibm.com>
Cc: "Michael S. Tsirkin" <mst@...hat.com>, Amit Shah <amit@...nel.org>,
        linux-kernel@...r.kernel.org, virtualization@...ts.linux.dev,
        arnd@...db.de, gregkh@...uxfoundation.org, brueckner@...ux.ibm.com,
        schnelle@...ux.ibm.com, Halil Pasic <pasic@...ux.ibm.com>
Subject: Re: [PATCH] virtio: console: Make resizing compliant with virtio
 spec

On Thu, 20 Mar 2025 12:53:43 +0100
Maximilian Immanuel Brandtner <maxbr@...ux.ibm.com> wrote:

> On Thu, 2025-03-20 at 11:41 +0100, Halil Pasic wrote:
> > On Thu, 20 Mar 2025 08:12:23 +0100
> > Maximilian Immanuel Brandtner <maxbr@...ux.ibm.com> wrote:
> >   
> > > > Another thing I noticed during looking at this. AFAICT Linux does
> > > > not
> > > > seem to handle endiannes here. And AFAIU the message is supposed
> > > > to
> > > > hold
> > > > le16 that is little endian u16! Maximilian, is this in your
> > > > opinion
> > > > something we need to fix as well? Or am I just missing the
> > > > conversion?
> > > > 
> > > > Regards,
> > > > Halil    
> > > 
> > > Thanks, I didn't notice that, as I only tested this feature on x86.
> > > I
> > > double checked struct virtio_console_config as it also defines cols
> > > before rows, but there the kernel follows the spec (including
> > > endianness).
> > > I'll send a patch v2 shortly.  
> > 
> > I can send a fix for the endiannes issue. It should be a separate
> > patch anyway.
> > 
> > Regards,
> > Halil  
> 
> I already implemented it in my patch v2 (just waiting for Amit to
> confirm the new commit message). But if you want to split it you can
> create a seperate patch for it as well (I don't really mind either
> way).
> 

It is conceptually a different bug and warrants a patch and a commit
message of its own. At least IMHO.

Regards,
Halil